Skip to content

ci: open the next release PR only once the release is tagged - #290

Merged
blaipr merged 1 commit into
mainfrom
ci/release-pr-after-tag
Nov 15, 2026
Merged

blaipr merged 1 commit into
mainfrom
ci/release-pr-after-tag

Conversation

@blaipr

@blaipr blaipr commented Nov 15, 2026

Copy link
Copy Markdown
Member

Problem

Merging the v0.38.0 release PR opened #289, chore: release v0.39.0, with v0.38.0's changelog in it. release-please ran both halves of its work in one step: it created v0.38.0 as a draft (no tag, by design, until the image is published) and then, in the same step, looked for the latest release to open the next PR. With no v0.38.0 tag yet it took v0.37.0 as the latest, counted every change since then again, and bumped 0.38.0 to 0.39.0. This was the first release cut by release-please, so it had not shown before.

Change

release.yml runs release-please twice, with the publish between them:

  1. Release (skip-github-pull-request): creates the draft release when the merge was a release PR's.
  2. Publish image, then the release: unchanged.
  3. Release PR (skip-github-release): opens or updates the next release PR and dispatches its CI. It runs after the publish, when the new tag exists, and is skipped when the publish failed; re-running the failed publish job runs it too.

docs/releasing.md describes the new step.

Compatibility

No change for users. #289 should be closed; the next merge opens a correct release PR.

Checklist

  • Docs updated (README.md, docs/, or CLAUDE.md) if behavior or config changed
  • The title reads as a CHANGELOG line for users (hidden: ci)

@blaipr
blaipr merged commit 676bfeb into main Nov 15, 2026
5 checks passed
@blaipr
blaipr deleted the ci/release-pr-after-tag branch November 15, 2026 00:37
blaipr added a commit to OpusProjects/unified-gitops that referenced this pull request Nov 15, 2026
## Problem

release-please ran both halves of its work in one step: it created the
release as a draft (no tag, by design, until the image is published) and
then, in the same step, looked for the latest release to open the next
PR. With the new tag not there yet, it takes the version before as the
latest, counts every change since then again and opens a release PR for
the version after the one being published. unified-api hit this
releasing v0.38.0 (a bogus `chore: release v0.39.0`); this workflow is
the same file.

## Change

`release.yml` runs release-please twice, with the publish between them,
as in unified-api (OpusProjects/unified-api#290):

1. **Release** (`skip-github-pull-request`): creates the draft release
when the merge was a release PR's.
2. **Publish image, then the release**: unchanged.
3. **Release PR** (`skip-github-release`): opens or updates the next
release PR and dispatches its CI. It runs after the publish, when the
new tag exists, and is skipped when the publish failed; re-running the
failed publish job runs it too.

`docs/releasing.md` describes the new step.

## Compatibility

No change for users.

## Checklist

- [x] Docs updated if behavior or config changed
- [x] The title reads as a CHANGELOG line for users (hidden: `ci`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant