Skip to content

fix(sqlserver): preserve IDENTITY columns when copying table (#1691) #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HandSonic wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −11
Open

fix(sqlserver): preserve IDENTITY columns when copying table (#1691) #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions ...2db-community-sqlserver/src/main/java/ai/chat2db/plugin/sqlserver/SqlServerDBManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,17 +162,26 @@ public void connectDatabase(Connection connection, String database) {

@Override
public void copyTable(Connection connection, String databaseName, String schemaName, String tableName, String newTableName, boolean copyData) throws SQLException {
String sourceTable = buildFullTableName(databaseName, schemaName, tableName);
String targetTable = buildFullTableName(databaseName, schemaName, newTableName);
String sql;
String ddl = Chat2DBContext.getDbMetaData().tableDDL(connection,
new TableMetadataRequest(databaseName, schemaName, tableName));
String createDdl = ddl.replace("[" + tableName + "]", "[" + newTableName + "]");
log.info("copy table DDL: {}", createDdl);
DefaultSQLExecutor.getInstance().execute(connection, createDdl, resultSet -> null);

if (copyData) {
sql = String.format(SQL_COPY_TABLE_DATA, targetTable, sourceTable);
} else {
sql = String.format(SQL_COPY_TABLE_STRUCTURE, targetTable, sourceTable);
String sourceTable = buildFullTableName(databaseName, schemaName, tableName);
String targetTable = buildFullTableName(databaseName, schemaName, newTableName);
String identityOn = String.format(SQL_SET_IDENTITY_INSERT, targetTable, "ON");
String identityOff = String.format(SQL_SET_IDENTITY_INSERT, targetTable, "OFF");
String insertSql = String.format(SQL_COPY_TABLE_DATA, targetTable, sourceTable);
log.info("copy table data sql: {}", insertSql);
try {
DefaultSQLExecutor.getInstance().execute(connection, identityOn, resultSet -> null);
DefaultSQLExecutor.getInstance().execute(connection, insertSql, resultSet -> null);
} finally {
DefaultSQLExecutor.getInstance().execute(connection, identityOff, resultSet -> null);
}
}

log.info(" copy table sql : {}", sql);
DefaultSQLExecutor.getInstance().execute(connection, sql, resultSet -> null);
}


Expand Down
4 changes: 2 additions & 2 deletions ...erver/src/main/java/ai/chat2db/plugin/sqlserver/constant/SqlServerDBManagerConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ public final class SqlServerDBManagerConstants {

public static final String SQL_DROP_TABLE_EXISTS = "DROP TABLE IF EXISTS ";
public static final String SQL_DROP_VIEW_EXISTS = "DROP VIEW IF EXISTS ";
public static final String SQL_COPY_TABLE_DATA = "SELECT * INTO %s FROM %s";
public static final String SQL_COPY_TABLE_STRUCTURE = "SELECT * INTO %s FROM %s WHERE 1=0";
public static final String SQL_COPY_TABLE_DATA = "INSERT INTO %s SELECT * FROM %s";
public static final String SQL_SET_IDENTITY_INSERT = "SET IDENTITY_INSERT %s %s";
public static final String SQL_DROP_TABLE = "DROP TABLE %s";
public static final String SQL_DROP_VIEW = "DROP VIEW %s";
public static final String SQL_USE_DATABASE = "use [%s];";
Expand Down