fix(community): isolate project sync events#1947
Conversation
There was a problem hiding this comment.
Reviewed 7506509: 0 critical, 1 high, 0 medium findings.
Merge recommendation: request changes. The concurrency key must distinguish Issue and pull-request event types when their numeric IDs match; otherwise an unrelated pending synchronization can be displaced.
Coverage: reviewed the complete current patches for both changed files plus PR metadata, existing reviews, and line comments. No tests or runtime checks were run.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpg
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
Generated by AI Pull Request Reviewer for #1947 · 7.5 AIC · ⌖ 1.57 AIC · ⊞ 17.8K
7506509 to
d01b443
Compare
d01b443 to
3a315c4
Compare
There was a problem hiding this comment.
Reviewed 3a315c46: 0 critical, 0 high, 0 medium findings.
Merge recommendation: no blocking findings. The prior high-severity concurrency collision is addressed by distinct issue and pull-request suffixes while scheduled and manual runs retain the shared reconcile key.
Coverage: reviewed the complete current patches for both changed files, PR metadata, existing reviews, and line comments. No tests or runtime checks were run.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpg
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
Generated by AI Pull Request Reviewer for #1947 · 5.66 AIC · ⌖ 2.77 AIC · ⊞ 16.9K
Superseded by updated review from same workflow.
Related issue
Closes #1946
Summary
reconcilekey.cancel-in-progress: false.Affected surfaces
Verification
node --test script/github/issue-claim.test.js script/github/sync-community-project.test.js- passed, 33 tests.ruby script/github/validate-community-operations.rb- passed.actionlint .github/workflows/community-project-sync.yml- passed.ruby -e 'require "yaml"; YAML.safe_load(File.read(".github/workflows/community-project-sync.yml"), aliases: false)'- passed.git diff --check- passed.Risk and compatibility
Reviewer map
.github/workflows/community-project-sync.yml, then the concurrency contract inscript/github/sync-community-project.test.js.Contributor declaration
AI assistance: Codex identified the cancellation pattern from live workflow runs, implemented the scoped concurrency key and test, and ran the reported verification. The maintainer retains responsibility for the workflow policy.