Skip to content

fix(clickhouse): preserve Decimal precision when scale is null #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aias00 wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −2
Open

fix(clickhouse): preserve Decimal precision when scale is null #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chat2db-community-client/src/components/SelectBoundInfo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,8 @@ const SelectBoundInfo = memo(

return (
<div className={styles.selectBoundInfo}>
{selectedList.map((item, index) => {
return <DropdownItem eachOption={item} key={index} handleOptionChange={handleOptionChange} />;
{selectedList.map((item) => {
return <DropdownItem eachOption={item} key={item.treeNodeType} handleOptionChange={handleOptionChange} />;
})}
</div>
);
Expand Down
36 changes: 36 additions & 0 deletions ...est/java/ai/chat2db/plugin/clickhouse/enums/type/ClickHouseColumnTypeEnumDecimalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package ai.chat2db.plugin.clickhouse.enums.type;

import ai.chat2db.community.domain.api.model.metadata.TableColumn;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertTrue;

class ClickHouseColumnTypeEnumDecimalTest {

private TableColumn column(String type, Integer size, Integer digits) {
TableColumn c = new TableColumn();
c.setColumnType(type);
c.setColumnSize(size);
c.setDecimalDigits(digits);
return c;
}

@Test
void decimalWithPrecisionOnly() {
// ClickHouse Decimal requires both P and S, so scale defaults to 0
String result = ClickHouseColumnTypeEnum.Decimal.buildCreateColumnSql(column("Decimal", 10, null));
assertTrue(result.contains("Decimal(10,0)"), () -> "Expected Decimal(10,0): " + result);
}

@Test
void decimalWithPrecisionAndScale() {
String result = ClickHouseColumnTypeEnum.Decimal.buildCreateColumnSql(column("Decimal", 10, 2));
assertTrue(result.contains("Decimal(10,2)"), () -> "Expected Decimal(10,2): " + result);
}

@Test
void decimalWithBothNull() {
String result = ClickHouseColumnTypeEnum.Decimal.buildCreateColumnSql(column("Decimal", null, null));
assertTrue(result.contains("Decimal"), () -> "Expected Decimal: " + result);
}
}
Loading