fix(sqlserver): escape SQL identifiers and literals in metadata/DDL paths (#1914)#2196
Open
HandSonic wants to merge 3 commits into
Open
fix(sqlserver): escape SQL identifiers and literals in metadata/DDL paths (#1914)#2196HandSonic wants to merge 3 commits into
HandSonic wants to merge 3 commits into
Conversation
…per maintainer review (OtterMind#1914) - strengthen SqlServerIdentifierProcessor (SPI ISQLIdentifierProcessor): quoteIdentifier always bracket-quotes with ] doubling, escapeString doubles single quotes only (no backslash doubling in T-SQL) - SqlServerMetaData.getSQLIdentifierProcessor() returns the shared INSTANCE; metadata call sites use it (statics use INSTANCE directly) - builders/DBManager/enums/XML+Geography value processors rewired to SqlServerIdentifierProcessor.INSTANCE / static escapeIdentifier - collation validation moved to public SqlServerSqlGuards - SqlServerIdentifierUtils removed; tests migrated to SqlServerIdentifierProcessorTest (49 green)
…quote for DDL paths (OtterMind#1914)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the SQL-injection hardening tracked in #1914. Prior art: #2052 (Oracle), #2053 (SQL Server), and the wave-1 batch (#2172-#2177).
These are second-order injection paths: values such as table/schema/view/index names originate from the connected database's own metadata, so exploitation requires a maliciously named object in a target database.
What changed (30 sites)
Completes PR #2053: adds escapeSqlLiteral to SqlServerIdentifierUtils and applies at remaining DDL/comment/metadata paths; XML/Geography DML values escaped with SQL Server semantics (quote-only doubling).
Verification
mvn -B -pl chat2db-community-plugins/chat2db-community-sqlserver -f chat2db-community-server/pom.xml -Dmaven.test.skip=false -DskipTests=false -Dsurefire.includes=**/*Test.java -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.test.failure.ignore=false testResult: Tests run: 49, Failures: 0, Errors: 0, Skipped: 0.
This branch also passed a two-lens adversarial review (escape-correctness/coverage + regression/test-efficacy); all blocking findings were fixed and re-tested before submission.