Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noble Containers #361

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Noble Containers #361

merged 3 commits into from
Feb 12, 2025

Conversation

alexcekay
Copy link
Member

@alexcekay alexcekay commented Feb 11, 2025

Solved Problem

As discussed in the dev call, we want to use a newer GCC version for compiling PX4 in the future, as newer versions take way less FLASH.

Solution

This PR creates new containers that are based oon Ubuntu Noble. As discussed we will use the GCC version shipped with Ubuntu Noble to compile on the CI. This is GCC13. I however needed to use the GCC13 version from ARM, as the one shipped via Noble did not compile due to: cannot read spec file 'nosys.specs': No such file or directory

I added myself as a maintainer, just to have something entered into the new files. Of course, if the container maintenance is defined differently, we can just change it.

Testing

I switched the CI jobs to use the containers of this PR in my fork: alexcekay/PX4-Autopilot#19

@alexcekay alexcekay changed the title Pr noble Noble containers Feb 11, 2025
@alexcekay alexcekay marked this pull request as ready for review February 11, 2025 17:25
@alexcekay alexcekay requested review from mrpollo and dagar February 11, 2025 17:28
@alexcekay alexcekay changed the title Noble containers Noble Containers Feb 11, 2025
@dagar
Copy link
Member

dagar commented Feb 11, 2025

Adding this to PX4-containers now seems fine, but if the goal is to shortly bump things within PX4-Autopilot we should just do that directly with the in tree Dockerfile + setup script.

If that's what you're talking about let's sync up tomorrow and just get it done?

@alexcekay alexcekay merged commit 72126af into master Feb 12, 2025
22 of 25 checks passed
@alexcekay alexcekay deleted the pr-noble branch February 12, 2025 08:46
@alexcekay
Copy link
Member Author

alexcekay commented Feb 13, 2025

Hi @dagar,

My target is to get the CI to build PX4 with GCC13. So I updated the containers to noble which uses GCC13.
As a next step I will create a PR on PX4-Autopilot that bumps the used docker containers to those new noble containers.
Basically the changes that can be seen here: https://github.com/alexcekay/PX4-Autopilot/pull/19/files
What exactly do you want to do instead?

Btw: Are you or @mrpollo admin of the PX4 docker hub account? There seems to be a problem pushing the containers to it:
https://github.com/PX4/PX4-containers/actions/runs/13281776545/job/37081533861. It looks like a credentials topic and I can't change the settings of this repo. Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants