Skip to content

Fix twitter cookie parsing regression#190

Closed
srxly888-creator wants to merge 1 commit intoPanniantong:mainfrom
srxly888-creator:codex/fix-twitter-cookie-parse
Closed

Fix twitter cookie parsing regression#190
srxly888-creator wants to merge 1 commit intoPanniantong:mainfrom
srxly888-creator:codex/fix-twitter-cookie-parse

Conversation

@srxly888-creator
Copy link

@srxly888-creator srxly888-creator commented Mar 22, 2026

What Changed / 更新内容

  • Refactored Cookie Parsing / 重构 Cookie 解析: Extracted the Twitter/X cookie parsing logic into a dedicated helper module for better maintainability.
    (将 Twitter/X 的 cookie 解析逻辑提取到了专用的辅助模块中,以提升代码的可维护性。)
  • Preserved Core Logic / 保留核心逻辑: Kept the existing configuration write behavior and the ~/.config/xfetch/session.json synchronization completely unchanged.
    (现有的配置写入行为,以及与 ~/.config/xfetch/session.json 的同步逻辑保持完全不变。)
  • Enhanced Test Coverage / 完善测试覆盖: Added comprehensive unit tests covering both supported input formats.
    (新增了全面的单元测试,已覆盖两种受支持的输入格式。)

Testing / 测试情况

Command Run / 执行命令:

PYTHONPATH=/Volumes/PS1008/Github/Agent-Reach pytest -q /Volumes/PS1008/Github/Agent-Reach/tests/test_cli.py

@Panniantong
Copy link
Owner

Thanks for the contribution! 🙏

I've rebased your changes onto the latest main (which now includes the bird migration from PR #193). All tests pass (10/10).

Since this is a fork PR and can't be rebased in-place, I've opened a new PR based on the rebased branch: see PR #196. Credit preserved in the commit.

Closing this in favor of the rebased version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants