Skip to content

Vox clothing#619

Open
ConsumoFurioso wants to merge 5 commits intoPentestSS13:masterfrom
ConsumoFurioso:VoxClothing
Open

Vox clothing#619
ConsumoFurioso wants to merge 5 commits intoPentestSS13:masterfrom
ConsumoFurioso:VoxClothing

Conversation

@ConsumoFurioso
Copy link

@ConsumoFurioso ConsumoFurioso commented Mar 10, 2026

About The Pull Request

Adds a proper Vox Variation sprite to the SRM Worksuit

Why It's Good For The Game

Properly made outfits are good.

🆑
add: Added Vox variation to the SRM Worksuit
/:cl:

A test in implementing clothing for Vox. I've made a sprite for the Rouma_Work uniform in the SRM.
I guess VSCode ripped a few things out so hopefully this fixes it!
Copy link
Collaborator

@Constellado Constellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review. A good first PR!

shiptest.dme Outdated
#include "code\_onclick\hud\screentip.dm"
#include "code\_onclick\hud\storage.dm"
#include "code\~PENTEST\~pentest.dme"
#inlcude "code\~PENTEST\~pentest.dme"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#inlcude "code\~PENTEST\~pentest.dme"
#include "code\~PENTEST\~pentest.dme"

Found a typo, fixing!

icon = 'icons/obj/clothing/faction/srm/uniforms.dmi'
mob_overlay_icon = 'icons/mob/clothing/faction/srm/uniforms.dmi'
supports_variations = KEPORI_VARIATION
supports_variations = KEPORI_VARIATION | VOX_VARIATION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines of codes can be modularized easily, my RTG PR that is here is a good example! However, we do need to test if it works in game like this first, though! I think Ossa offered to help if the sprite doesn't show up correctly in game like you mentioned in discord.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will end up taking care of this once everything is working as I know the sprite might need adjustments so that it aligns correctly.

@Constellado Constellado added good first issue Good for newcomers Modularization Requested Additional Modularization might be required/requested or fixes to modularization. labels Mar 10, 2026
@OnlineGirlfriend
Copy link
Contributor

OnlineGirlfriend commented Mar 10, 2026

you don’t have to include the dme fix in the changelog as it was just a fix internal to this PR, ultimately nothing will actually change there on the server end

Copy link
Collaborator

@Ossa88 Ossa88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing a typo of a typo

@github-actions github-actions bot requested review from Constellado and Ossa88 March 10, 2026 05:03
@github-actions github-actions bot removed the DME Edit label Mar 10, 2026
Changed icon state from "rouma_Work" to "rouma_work"
@github-actions github-actions bot requested a review from Ossa88 March 10, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Change good first issue Good for newcomers Modularization Requested Additional Modularization might be required/requested or fixes to modularization. Sprites

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants