feat(v2): validate server identify and alias delivery - #65
dustinbyrne wants to merge 3 commits into
Conversation
parallel-adapter Compliance ReportDate: 2026-09-22T19:21:55.861584+00:00 ✅ All Tests Passed!17/17 tests passed Feature_Flags Tests✅ 17/17 tests passed View Details
|
minimal-adapter Compliance ReportDate: 2026-09-22T19:22:04.575077+00:00 ✅ All Tests Passed!17/17 tests passed Feature_Flags Tests✅ 17/17 tests passed View Details
|
|
The behavior appears safe, but the async test must be changed to avoid blocking synchronous file I/O before merging because it violates an explicit repository requirement. Reviews (1) · Last reviewed commit: "test(v2): select in-place server identit..." |
| feature.read_text().replace("an isolated SDK with empty persistent storage", "an isolated SDK instance") | ||
| ) |
There was a problem hiding this comment.
This async test calls Path.read_text() and Path.write_text() directly, blocking the event loop. This violates the repository directive to flag synchronous file I/O in async Python. Move the feature rewrite into a synchronous fixture or helper, or offload the file operations to a thread. This repository requirement must be satisfied before merging.
Context Used: Be direct and concise: state the issue, its impact, and the fix, with no preamble or praise. Do not comment on alphabetical sorting, trailing commas, or formatting. Linters catch these. Judge code by four simplicity rules: it passes all the tests, ex... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/test_v2_identify_alias.py
Line: 204-205
Comment:
**Blocking I/O in async test**
This async test calls `Path.read_text()` and `Path.write_text()` directly, blocking the event loop. This violates the repository directive to flag synchronous file I/O in async Python. Move the feature rewrite into a synchronous fixture or helper, or offload the file operations to a thread. This repository requirement must be satisfied before merging.
**Context Used:** Be direct and concise: state the issue, its impact, and the fix, with no preamble or praise. Do not comment on alphabetical sorting, trailing commas, or formatting. Linters catch these. Judge code by four simplicity rules: it passes all the tests, ex... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Problem
The draft2 runner can observe received events but cannot inspect a private SDK queue. Server identify and alias acceptance cases should be executable through public adapter calls and received-event assertions.
Changes
/identifyand/aliasfor JSON arguments using the existing adapter call and native-throw handling.trueis not1), updating regressions that previously accepted false matches. Keep the 157-case migration selection and v1 runner unchanged. Add Sampo minor release metadata for the new v2 actions; do not change the pinned specs revision or CI defaults.Validation
git diff --check, Black and Ruff passed on edited files; read-only reviewer found no issues.