Skip to content

UI Improvement for Mobile and Tablets#77

Open
shaurya35 wants to merge 8 commits intoPranavBarthwal:mainfrom
shaurya35:responsiveness
Open

UI Improvement for Mobile and Tablets#77
shaurya35 wants to merge 8 commits intoPranavBarthwal:mainfrom
shaurya35:responsiveness

Conversation

@shaurya35
Copy link
Copy Markdown
Contributor

UI Improvement for Mobile and Tablets

Issue number: #20

Video/Screenshots

Feature-1

vid2.mp4
  • Summary- Restructured most of the overflowing and out-of-bound contents and aligned them according to the requirements for smaller devices.

Feature-2

vid3.mp4
  • Summary- Implemented a sidebar for mobile devices, keeping all the elements on desktop version exactly same.

Feature-3

vid1.mp4
  • Summary- Menu gets closed if clicked on a button, and its fully optimized for all test cases.

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented on my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

Shaurya | Gssoc Contributor
Happy to collaborate on more features.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 11, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@shaurya35
Copy link
Copy Markdown
Contributor Author

@PranavBarthwal

I am not able to detect why its conflicting the main branch, its literally the same,

Screenshot 2024-05-12 053011

I think you will be able to merge it without any problems.

Copy link
Copy Markdown
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaurya35 I cant see the drawer.
In full width, the apod image is overflowing from the container.
Please fix all these issues, Dont make changes in existing UI just make it responsive for mobile and tablet.

@shaurya35
Copy link
Copy Markdown
Contributor Author

@PranavBarthwal can you explain the problem in detail, I didn't get the point

did you mean the sidebar from the hamburger menu?

@shaurya35
Copy link
Copy Markdown
Contributor Author

@PranavBarthwal Got the issue, and fixed it completely
You may check it out.

Happy to make more improvements.

@shaurya35 shaurya35 mentioned this pull request May 16, 2024
3 tasks
@PranavBarthwal
Copy link
Copy Markdown
Owner

Can you please resolve the merge conflicts.

@shaurya35
Copy link
Copy Markdown
Contributor Author

Hi @PranavBarthwal
I will need to talk to you about the same.
Will you be able to come to Discord for like 10 minutes?
There are some issues we will need to figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants