Skip to content

Dev #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 278 commits into
base: main
Choose a base branch
from
Open

Dev #35

wants to merge 278 commits into from

Conversation

@Nummun14
Copy link
Member

@Nummun14 Nummun14 commented Oct 21, 2024

No description provided.

Strflightmight09 and others added 30 commits September 13, 2024 18:07
@Strflightmight09
Reordered
8eda89f
@Strflightmight09
Fixed?
e0e6be5
@Strflightmight09
Renamed and converted degrees to radians
c413fde
@Strflightmight09
Added javadoc
2ca71c9
@Strflightmight09
Made changing the best target if needed easier
0ed359f
@Strflightmight09
Reordered
8245c2c
@Strflightmight09
Clean
e588f20
@Strflightmight09
Fixed problem
73bb5ba
@Strflightmight09
Reformatted
eea45cd
@Strflightmight09
Updated TRIGONLib
59d92b2
@Strflightmight09
Fixed bug
6fa239f
@Strflightmight09
Removed PhotonPoseEstimator
10655c5
@Strflightmight09
Reordered and renamed
5438a84
@Strflightmight09
Fixed order and extensive logging
e10c5f8
@Strflightmight09
Removed redundant checks
6293822
@Strflightmight09
Added changes from after testing (still more to do though)
7c4e721
@Strflightmight09
Fixed logic problems and updated to new pose estimation method
9daaacb
@Strflightmight09
Removed vars
2d5f521
@Strflightmight09
Reverted to only solvePNP 😢
85e4451
@Strflightmight09
Merge branch 'main' into vision-fixes
1d582fa
@Nummun14
pitcher ff
a408d1c
@Strflightmight09
Fixed pitcher (I think) and started shooter stuff
c7f3f3c
@Strflightmight09
Calibrated shooter
9af71d6
@Strflightmight09
Updated pitcher constants. Still needs calibration
b21eb8f
@Nummun14
Merge branch 'main' into calibrations
d67aa6b
@Nummun14
updated gear ratio
2344e02
@Nummun14
pitcher is still overshooting by 2 degrees
871c0f9
@Nummun14
added shooter FF
309c178
@Strflightmight09
Completed shooter PID
1295df8
@Strflightmight09
Calibrated AmpAligner
53105c3
Nummun14
Nummun14 commented Nov 12, 2024
View reviewed changes
Copy link
Member Author

@Nummun14 Nummun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started review

Nummun14
Nummun14 commented Nov 12, 2024
View reviewed changes
Nummun14
Nummun14 commented Nov 13, 2024
View reviewed changes
Nummun14
Nummun14 commented Nov 13, 2024
View reviewed changes
levyishai
levyishai requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@levyishai levyishai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed things that matter for the template

levyishai
levyishai requested changes Nov 17, 2024
View reviewed changes
levyishai
levyishai requested changes Nov 17, 2024
View reviewed changes
Nummun14
Nummun14 commented Nov 22, 2024
View reviewed changes
Nummun14
Nummun14 commented Nov 24, 2024
View reviewed changes
Copy link
Member Author

@Nummun14 Nummun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

levyishai
levyishai requested changes Nov 25, 2024
View reviewed changes
src/main/java/frc/trigon/robot/commands/AlignToNoteCommand.java
addCommands(
getSetCurrentLEDColorCommand().asProxy(),
GeneralCommands.getContinuousConditionalCommand(getDriveWhileAligningToNoteCommand(), GeneralCommands.duplicate(CommandConstants.SELF_RELATIVE_DRIVE_COMMAND), this::hasTarget).asProxy(),
getSetCurrentLEDColorCommand(),
Copy link
Member

@levyishai levyishai Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not proxy?

Copy link
Member

@Strflightmight09 Strflightmight09 Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function I'm calling runs it as a proxy

Copy link
Member

@levyishai levyishai Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay
Is this fully tested?

src/main/java/frc/trigon/robot/commands/LEDAutoSetupCommand.java

private Pose2d getCurrentRobotPose() {
return RobotContainer.POSE_ESTIMATOR.getCurrentPose();
return RobotContainer.POSE_ESTIMATOR.getCurrentEstimatedPose();
Copy link
Member

@levyishai levyishai Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function seems rather useless

Copy link
Member

@Strflightmight09 Strflightmight09 Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cleans it up

Copy link
Member

@levyishai levyishai Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gives more ambiguity on where the pose is coming from
No need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levyishai levyishai levyishai requested changes

@Strflightmight09 Strflightmight09 Strflightmight09 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nummun14 @levyishai @Strflightmight09