New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nahum #5

Open

Nummun14 wants to merge 212 commits into main from arm-Nahum

Member

Nummun14 commented Nov 8, 2023

No description provided.

Nummun14 added 4 commits

November 8, 2023 20:34


          InitiatedCanSparkMotors

63b0ccb


          added PIDControler

36c5c3c


          added TalonSRX

a833f5c


          attempted to add cancoder

e74b59c

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/arm/arm.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java Outdated Show resolved Hide resolved

Nummun14 added 3 commits

November 9, 2023 09:35


          Made Can_Spark_Config

050897d


          removed ExtraNewLine

5826d79


          fixed angle encoder config

6546c54

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

Nummun14 added 9 commits

November 9, 2023 10:12


          fixed enum

d499b63


          removed extra new lines

03a04c8


          corrected type of canCOder

d3126b5


          added follower motors

51ecd48


          Made TalonSRX configuration

a5194f2


          made elevator encoder

d0ab93e


          removed redundent code

77e39a0


          corrected enum

af0ec9c


          added canCoder config

d56fa7a

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

Nummun14 added 5 commits

November 9, 2023 20:04


          corrected names

9315c1d


          corrected enum made code cleaner

6d51eb6


          added inverted to encoders

8bffce3


          ctrl alt l

94c9ade


          added offset to elevatorencoder

b132590

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved


          fixed code acording to review

a86c2c3

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved


          fixed coder acording to review

4d0c790

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java Outdated Show resolved Hide resolved


          Updated acording to review

931356a

Nummun14 added 5 commits

December 17, 2023 15:35


          corrected mechanism, and turret names

a029de6


          added simulation

b3d2c41


          removed redundent constants

4a04d4c


          corrected logic of calculateTargetAngle

3c63367


          corrected mechaism

6c62c82

levyishai requested changes

View reviewed changes

...main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/TurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/TurretCommands.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved


          corrected names and tested

12c6e1a

levyishai reviewed

View reviewed changes

Member

levyishai left a comment •

edited

Loading

Read about MotionMagic and implement it in the code. This is why you didn't use profiles for the rest of the clas yet. (Note that the simulation will use profiles in order to match what motion magic does.)
And in second thought, use a mechanism for now to visualize until you can have the full robot visualization.

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java Outdated Show resolved Hide resolved


          minor fixes

96cac05

Strflightmight09 reviewed

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java Outdated Show resolved Hide resolved

Strflightmight09 reviewed

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java Outdated Show resolved Hide resolved

Nummun14 added 5 commits

December 20, 2023 22:55


          minor fixes

a66c1a3


          added motion magic

ec46d1c


          added mech2d

e8c1573


          added mechanism

318a7ea


          attempted to fix mechanism

c2612fe

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/RobotContainer.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/TurretConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/TurretConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java Outdated Show resolved Hide resolved

...main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved

Nummun14 added 2 commits

December 21, 2023 18:47


          fixed status signals

2f06d9f


          fixed robotContainer

156f017

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/TurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved


          minor fixes

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/turret/Turret.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/TurretCommands.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java Outdated Show resolved Hide resolved

...main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretConstants.java Outdated Show resolved Hide resolved

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved

levyishai requested changes

View reviewed changes

src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java Outdated Show resolved Hide resolved


          tuned PID, and added runCommand

Member Author

Nummun14 commented Dec 24, 2023

my mechaism isn't working idk why

it doesn't move, it just stays like that the whole time

Member

levyishai commented Dec 24, 2023

my mechaism isn't working idk why it doesn't move, it just stays like that the whole time

Try removing the auto log output annotation

Member Author

Nummun14 commented Dec 24, 2023

my mechaism isn't working idk why it doesn't move, it just stays like that the whole time

Try removing the auto log output annotation

doesn't change anything

Member

levyishai commented Dec 24, 2023

my mechaism isn't working idk why it doesn't move, it just stays like that the whole time

Try removing the auto log output annotation

doesn't change anything

Weak pid?

Member Author

Nummun14 commented Dec 24, 2023 •

edited

Loading

my mechaism isn't working idk why it doesn't move, it just stays like that the whole time

Try removing the auto log output annotation

doesn't change anything

Weak pid?

But it was working a second ago, then I committed my changes and it stopped working. I think it stopped working after I set the goal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet