Fix swapped unrealized/realized PnL in IB updatePortfolio#222
Open
katchke wants to merge 1 commit intoQuantConnect:masterfrom
Open
Fix swapped unrealized/realized PnL in IB updatePortfolio#222katchke wants to merge 1 commit intoQuantConnect:masterfrom
katchke wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
IB EWrapper passes unrealizedPNL then realizedPNL after averageCost. Parameter names were reversed relative to binding, so values were swapped when passed to UpdatePortfolioEventArgs (logs showed closed P&L under UnrealisedPnl). Fixes QuantConnect#112 Made-with: Cursor
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns
InteractiveBrokersClient.updatePortfolioparameter names with IBEWrapper.updatePortfolio:averageCost, unrealizedPNL, realizedPNL,accountName.The previous names (
realisedPnl,unrealisedPnl) were reversed relative to the actual slot binding, soUpdatePortfolioEventArgsreceived swapped values—e.g. closed position P&L appearing underUnrealisedPnl(see #112).Change
doubleparameters tounrealisedPnl,realisedPnlin declaration order. TheUpdatePortfolioEventArgs(...)call is unchanged and is now correct.Fixes #112