Skip to content

Fix swapped unrealized/realized PnL in IB updatePortfolio #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katchke wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix swapped unrealized/realized PnL in IB updatePortfolio #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions QuantConnect.InteractiveBrokersBrokerage/Client/InteractiveBrokersClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.
* Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.
*
Expand Down Expand Up @@ -450,7 +450,7 @@ public override void updateAccountValue(string key, string value, string currenc
/// <param name="realisedPnl">Shows your profit on closed positions, which is the difference between your entry execution cost (execution price + commissions to open the position) and exit execution cost ((execution price + commissions to close the position)</param>
/// <param name="accountName">The name of the account to which the message applies. Useful for Financial Advisor sub-account messages.</param>
public override void updatePortfolio(Contract contract, decimal position, double marketPrice, double marketValue, double averageCost,
double realisedPnl, double unrealisedPnl, string accountName)
double unrealisedPnl, double realisedPnl, string accountName)
{
var positionValue = Convert.ToInt32(position);
OnUpdatePortfolio(new UpdatePortfolioEventArgs(contract, positionValue, marketPrice, marketValue, averageCost, unrealisedPnl, realisedPnl,
Expand Down