-
Notifications
You must be signed in to change notification settings - Fork 29
core3ext: reattach assigned USB devices on resume from suspend #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5e0bc9b to
9890f83
Compare
|
Ignore my original change, I'd incorrectly written this to use |
|
Shouldn't this take some lock or something to avoid parallel double-attach in the non-S0ix case? IIUC there you'll see re-enumeration of devices too, which will trigger attaching them too - and that might happen concurrently with |
9890f83 to
c1226c2
Compare
Yeah, you're right. I've added a dict of per-VM async locks that are taken on entry to the |
35981c4 to
c643e60
Compare
|
@marmarek anything blocking this from being merged? |
|
Test need an update: https://openqa.qubes-os.org/tests/158669#step/TC_30_USBProxy_core3/1 |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026021104-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/166096#dependencies 33 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:12 performance degradations
Remaining performance tests:98 tests
|
This patch ensures USB devices are reattached on resume, which is necessary for S0ix since we don't detach the USB controller drivers and hence the udev rules aren't retriggered automatically.
c643e60 to
402a8b9
Compare
|
Hey, apologies for the delay on this @marmarek. I've added the missing uuid property to the TestVM instance, hopefully it should pass OK now. |
This patch ensures USB devices are reattached on resume, which is necessary for S0ix since we don't detach the USB controller drivers and hence the udev rules aren't retriggered automatically. I've relocated the attachment logic into
_auto_attach_devices, which is now shared between the domain-start and domain-resumed handlers.I've also added a new event, domain-resumed, in core-admin to support this since domain-unpaused isn't sufficient for our needs. That PR can be found here and is a dependency for this change: QubesOS/qubes-core-admin#725