Allow GUIVM clients to know if GUIVM has session#625
Merged
marmarek merged 1 commit intoQubesOS:mainfrom Mar 17, 2026
Merged
Conversation
32 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
+ Coverage 69.89% 70.30% +0.40%
==========================================
Files 3 3
Lines 495 495
==========================================
+ Hits 346 348 +2
+ Misses 149 147 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Non-dom0 GUIVM doesn't have |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
e0c91d7 to
269ead4
Compare
Contributor
Author
|
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
269ead4 to
924ab70
Compare
Member
|
It's okay to use qvm-prefs here - GUI domain has access to it anyway. |
Contributor
Author
It is just to have a single script to copy around both places. If you really don't want it, I can remove the dom0 part from here. |
Member
|
In this repository I'd prefer to keep just VM part (AKA no dead code). It would make sense if the same script would be in a package installed in both dom0 and VM - we don't have such gui-agent/gui-daemon related package, but maybe linux-utils? Note that moving file between packages requires careful package dependencies, for the package manager to not complain about conflicting files. Debian has specific guidelines for that, maybe Fedora has something like this too? |
Contributor
Author
|
Didn't find Fedora's guidelines, just Debian's.
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
https://wiki.debian.org/PackageTransition -> number 10
For Fedora, will probably be a mix of Conflicts, Obsoletes, Requires keys
bound to versions. @fepitre, any insight on this?
…On Tue, Dec 2, 2025, 7:52 PM Marek Marczykowski-Górecki < ***@***.***> wrote:
*marmarek* left a comment (QubesOS/qubes-core-agent-linux#625)
<#625 (comment)>
In this repository I'd prefer to keep just VM part (AKA no dead code). It
would make sense if the same script would be in a package installed in both
dom0 and VM - we don't have such gui-agent/gui-daemon related package, but
maybe linux-utils? Note that moving file between packages requires careful
package dependencies, for the package manager to not complain about
conflicting files. Debian has specific guidelines for that, maybe Fedora
has something like this too?
—
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCE2O4P7S4WXPGXVALR5AYD37XNXPAVCNFSM6AAAAACNZDRI7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBTGUYTMMJQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This was referenced Dec 3, 2025
This was referenced Dec 3, 2025
Contributor
Author
linux-utils doesn't seem to have RPCs. What about maintaining on qubes-core-qrexec repo but moving from packge qubes-core-qrexec to qubes-core-qrexec? |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
924ab70 to
1f3b3be
Compare
Contributor
Author
|
Would be very nice if CI could combine this PR with: To test if the packaging is right. In the meantime, I will do manually. I don't have this process streamlined yet. |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
1f3b3be to
ef3eb5e
Compare
Contributor
Author
I am still fixing some conflicts by:
And I see this is still tagged with openqa-pending, so I hope to get it fixed before it is openqaed. |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
cb194c9 to
ea3c088
Compare
Contributor
Author
|
Packaging is broken... |
marmarek
reviewed
Dec 3, 2025
| Replaces: | ||
| qubes-core-qrexec (<< 4.3.12) | ||
| Breaks: | ||
| qubes-core-qrexec (<< 4.3.12) |
Member
There was a problem hiding this comment.
This should be the other way around - qrexec package declaring those on core-agent
marmarek
reviewed
Dec 3, 2025
| Requires: zenity | ||
| Requires: dconf | ||
| Requires: qubes-core-qrexec-vm >= 4.2.19 | ||
| Obsoletes: qubes-core-qrexec < 4.3.12 |
Member
There was a problem hiding this comment.
I don't think obsoletes is relevant here. But qrexec may need similar Conflict: dependency (to force update ordering)
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
420e90f to
e7db241
Compare
This was referenced Jan 9, 2026
This was referenced Feb 3, 2026
Merged
This was referenced Mar 2, 2026
Add disk2 status and update volume retrieval method
QubesOS/qubes-desktop-linux-i3-settings-qubes#23
Open
This was referenced Mar 15, 2026
It is also used by dom0, to avoid duplication, merge into a single package. For: QubesOS/qubes-notification-proxy#13 For: QubesOS/qubes-gui-agent-linux#251 For: QubesOS/qubes-core-admin#757 For: QubesOS/qubes-issues#1512 For: QubesOS/qubes-issues#9940 Fixes: QubesOS/qubes-issues#10443
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
e7db241 to
9ae685c
Compare
marmarek
added a commit
to QubesOS/qubes-core-qrexec
that referenced
this pull request
Mar 17, 2026
* origin/pr/217: Change WaitForSession to wait for user session Read link to canonical path Pull request description: Read link to canonical path of GUID file By default, it resolves the link path literally, which causes problem if other commands do not run on the same directory the link is at. For: QubesOS/qubes-core-admin#757 For: QubesOS/qubes-notification-proxy#13 For: QubesOS/qubes-issues#9940 For: QubesOS/qubes-issues#1512 --- Allow GUIVM clients to know if GUIVM has session Or if GUID of the client can be found on the server. This script will be replicated to qubes-core-agent-linux. For: QubesOS/qubes-notification-proxy#13 For: QubesOS/qubes-gui-agent-linux#251 For: QubesOS/qubes-core-admin#757 For: QubesOS/qubes-issues#1512 For: QubesOS/qubes-issues#9940 Fixes: QubesOS/qubes-issues#10443 --- Test case: ``` QREXEC_REMOTE_DOMAIN=mydomain /etc/qubes-rpc/qubes.WaitForSession ``` --- Please note that to avoid package conflicting (having the same file), it has to be handled with "less than version" compared to core-agent-linux https://github.com/QubesOS/qubes-core-qrexec/compare/223f3b596259adf299988f1171df8572d0204a0c..0dc90060ad27e90487572f0609453b5c564f4be7 See required PR: - QubesOS/qubes-core-agent-linux#625
marmarek
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or if GUID of the client can be found on the server. This script is replicated on qubes-core-qrexec.
For: QubesOS/qubes-notification-proxy#13
For: QubesOS/qubes-gui-agent-linux#251
For: QubesOS/qubes-core-admin#757
For: QubesOS/qubes-issues#1512
For: QubesOS/qubes-issues#9940
Fixes: QubesOS/qubes-issues#10443
Please note that this requires version bump of core-qrexec to avoid conflicting package (same file name):