re-add qubesadmin.tags import

[marmarek]

Fixes: 4a282a2 "add type hints for app.py"

[marmarek]

@hippalectryon-0 I'm not sure why unittests/pylint didn't failed, but it exploded on openQA: https://openqa.qubes-os.org/tests/169768#step/update2/50

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.35%. Comparing base (71fab5b) to head (cbdd653).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   76.35%   76.35%           
=======================================
  Files          53       53           
  Lines        9388     9389    +1     
=======================================
+ Hits         7168     7169    +1     
  Misses       2220     2220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hippalectryon-0]

Could it be that the tests mock the QubesVM class ? (in which case that seems a bit scary, that's a fairly important class to test)

[marmarek]

Maybe it's because qubesadmin.tests.tags is run earlier and that imports qubesadmin.tags? That's the only other place where I can find this import...

[hippalectryon-0]

That's definitely a possibility. Python import order-related issues can be fairly sneaky.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026031512-4.3&flavor=pull-requests

Test run included the following:

• Add option to wait for GUI session qubes-app-linux-input-proxy#42 (QubesOS/qubes-app-linux-input-proxy@cd6d205)
• Add Arch packaging #332 (71b1e21)
• version 4.3.999 #454 (fa35e91)
• re-add qubesadmin.tags import #456 (cbdd653)
• tests: log more info on failure qubes-core-admin#736 (QubesOS/qubes-core-admin@a3fc21c)
• Allow GUIVM clients to know if GUIVM has session qubes-core-agent-linux#625 (QubesOS/qubes-core-agent-linux@e7db241)
• minimal-vms: mask gvfs-daemon to prevent dbus timeout qubes-core-agent-linux#636 (QubesOS/qubes-core-agent-linux@c28c0f1)
• Query GUIVM session or GUID from client in GUIVM qubes-core-qrexec#217 (QubesOS/qubes-core-qrexec@5dc1b28)
• Add disk2 status and update volume retrieval method qubes-desktop-linux-i3-settings-qubes#23 (QubesOS/qubes-desktop-linux-i3-settings-qubes@8b3f6d3)
• Rewrite qubes-i3-sensible-terminal qubes-desktop-linux-i3-settings-qubes#24 (QubesOS/qubes-desktop-linux-i3-settings-qubes@34e4251)
• Delay connecting with gui-daemon until after starting Xorg qubes-gui-agent-linux#251 (QubesOS/qubes-gui-agent-linux@a981e36)
• Don't hang is-system-running when GUI is disabled qubes-gui-agent-linux#255 (QubesOS/qubes-gui-agent-linux@9129d1c)
• Fix reporting error status for multi-command actions qubes-mgmt-salt-base#20 (QubesOS/qubes-mgmt-salt-base@53ec41a)
• Allow GUIVM clients to know if GUIVM has session qubes-mgmt-salt-dom0-virtual-machines#88 (QubesOS/qubes-mgmt-salt-dom0-virtual-machines@4c3007f)
• Wait for GUI session on the server side qubes-notification-proxy#14 (QubesOS/qubes-notification-proxy@6da96ee)

Installing updates failed, skipping the report!