qvm-start-daemon: Pass KDE specific guid arguments for stubdomain too#313
Merged
marmarek merged 1 commit intoQubesOS:mainfrom Oct 16, 2024
Merged
qvm-start-daemon: Pass KDE specific guid arguments for stubdomain too#313marmarek merged 1 commit intoQubesOS:mainfrom
marmarek merged 1 commit intoQubesOS:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 75.10% 75.10%
=======================================
Files 52 52
Lines 8552 8552
=======================================
Hits 6423 6423
Misses 2129 2129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CertainLach
approved these changes
Oct 15, 2024
Contributor
CertainLach
left a comment
CertainLach
left a comment
There was a problem hiding this comment.
Works on NixOS-Qubes 4.3
This was referenced Oct 16, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024101520-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests73 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable testsDetails
|
This was referenced Oct 16, 2024
marmarek
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs backport to 4.2 (actually I only tested it there)