-
-
Notifications
You must be signed in to change notification settings - Fork 126
network: reload firewall rules on DNS change #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When DNS changes (for example after switching network, or connecting VPN) it is possible that some names will resolve to different addresses. 2256411 "network: Update specialtarget=dns rules on DNS change" handled one specific case of DNS firewall rules specifically, change it to reloading the whole firewall instead. This also fixes the case where qubes-firewall is not enabled at all. Fixes QubesOS/qubes-issues#10444
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025122104-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests57 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 14 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:32 performance degradations
Remaining performance tests:119 tests
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 71.18% 69.89% -1.30%
==========================================
Files 3 3
Lines 479 495 +16
==========================================
+ Hits 341 346 +5
- Misses 138 149 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When DNS changes (for example after switching network, or connecting VPN)
it is possible that some names will resolve to different addresses.
2256411 "network: Update specialtarget=dns rules on DNS change" handled
one specific case of DNS firewall rules specifically, change it to
reloading the whole firewall instead.
This also fixes the case where qubes-firewall is not enabled at all.
Fixes QubesOS/qubes-issues#10444