Skip to content

Fix wrong event name #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marmarek merged 1 commit into from
Oct 10, 2025
Merged

Fix wrong event name #71

marmarek merged 1 commit into from
Oct 10, 2025

Conversation

@ben-grande
Copy link

@ben-grande ben-grande commented Oct 2, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.07%. Comparing base (52bb2db) to head (908ae5b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   62.07%   62.07%           
=======================================
  Files           2        2           
  Lines         683      683           
=======================================
  Hits          424      424           
  Misses        259      259
Flag Coverage Δ
unittests 62.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Oct 3, 2025
Merged
Open
Merged
Merged
Merged
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Oct 3, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025101005-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update

Failed tests

17 failures

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/149225#dependencies

83 fixed

  • system_tests_audio@hw1

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.audio failed (exit code 1), details reporte...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_224_audio_rec_muted_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...

  • system_tests_dispvm_perf@hw7

  • system_tests_guivm_gpu_gui_interactive@hw13

    • guivm_startup: wait_serial (wait serial expected)
      # wait_serial expected: qr/lEcbc-\d+-/...

    • guivm_startup: Failed (test died + timed out)
      # Test died: command '! qvm-check sys-whonix || time qvm-start sys-...

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_audio

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.audio failed (exit code 1), details reporte...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_224_audio_rec_muted_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_basic_vm_qrexec_gui_ext4

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.vm_qrexec_gui failed (exit code 1), details...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_NonAudio_whonix-gateway-17-pool: test_012_qubes_desktop_run (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError

  • system_tests_dispvm

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.dispvm failed (exit code 1), details report...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_DispVM_debian-13-xfce: test_012_preload_low_mem (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0

    • TC_20_DispVM_debian-13-xfce: test_013_preload_gui (error)
      raise KeyError(key)... KeyError: 'disp3723'

    • TC_20_DispVM_debian-13-xfce: test_014_preload_nogui (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError

    • TC_20_DispVM_debian-13-xfce: test_015_preload_race_more (error + cleanup)
      raise KeyError(key)... KeyError: 'disp1187'

    • TC_20_DispVM_debian-13-xfce: test_016_preload_race_less (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_20_DispVM_debian-13-xfce: test_017_preload_autostart (error)
      raise KeyError(key)... KeyError: 'disp7317'

    • TC_20_DispVM_debian-13-xfce: test_018_preload_global (error)
      raise KeyError(key)... KeyError: 'disp8572'

    • TC_20_DispVM_debian-13-xfce: test_019_preload_refresh (error)
      raise KeyError(key)... KeyError: 'disp6425'

    • TC_20_DispVM_fedora-42-xfce: test_012_preload_low_mem (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0

    • TC_20_DispVM_whonix-workstation-17: test_012_preload_low_mem (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0

Unstable tests

Details

Performance Tests

Performance degradation:

13 performance degradations
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 214784.00 🔻 ( previous job: 497426.00, degradation: 43.18%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 175061.00 🔻 ( previous job: 265260.00, degradation: 66.00%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 130914.00 🔻 ( previous job: 431512.00, degradation: 30.34%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 46890.00 🔻 ( previous job: 196254.00, degradation: 23.89%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 17370.00 🔻 ( previous job: 23940.00, degradation: 72.56%)
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 217276.00 🔻 ( previous job: 299764.00, degradation: 72.48%)
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8134.00 🔻 ( previous job: 9042.00, degradation: 89.96%)
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1220.00 🔻 ( previous job: 1368.00, degradation: 89.18%)
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 70901.00 🔻 ( previous job: 79539.00, degradation: 89.14%)
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1065.00 🔻 ( previous job: 1251.00, degradation: 85.13%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3214.00 🔻 ( previous job: 4098.00, degradation: 78.43%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7531.00 🔻 ( previous job: 8804.00, degradation: 85.54%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1265.00 🔻 ( previous job: 2384.00, degradation: 53.06%)

Remaining performance tests:

166 tests
  • debian-13-xfce_exec: 7.74 🟢 ( previous job: 8.36, improvement: 92.57%)
  • debian-13-xfce_exec-root: 26.50 🟢 ( previous job: 27.36, improvement: 96.86%)
  • debian-13-xfce_socket: 8.72 🔻 ( previous job: 8.57, degradation: 101.68%)
  • debian-13-xfce_socket-root: 7.84 🟢 ( previous job: 8.26, improvement: 94.96%)
  • debian-13-xfce_exec-data-simplex: 58.98 🟢 ( previous job: 72.43, improvement: 81.43%)
  • debian-13-xfce_exec-data-duplex: 69.25 🟢 ( previous job: 76.65, improvement: 90.35%)
  • debian-13-xfce_exec-data-duplex-root: 72.19 🟢 ( previous job: 91.79, improvement: 78.65%)
  • debian-13-xfce_socket-data-duplex: 79.60 🟢 ( previous job: 133.45, improvement: 59.65%)
  • fedora-42-xfce_exec: 8.92 🟢 ( previous job: 9.06, improvement: 98.42%)
  • fedora-42-xfce_exec-root: 59.09 🔻 ( previous job: 58.19, degradation: 101.56%)
  • fedora-42-xfce_socket: 8.56 🔻 ( previous job: 8.48, degradation: 100.97%)
  • fedora-42-xfce_socket-root: 7.67 🟢 ( previous job: 8.18, improvement: 93.76%)
  • fedora-42-xfce_exec-data-simplex: 59.32 🟢 ( previous job: 78.48, improvement: 75.59%)
  • fedora-42-xfce_exec-data-duplex: 64.11 🟢 ( previous job: 67.92, improvement: 94.39%)
  • fedora-42-xfce_exec-data-duplex-root: 90.56 🟢 ( previous job: 96.36, improvement: 93.98%)
  • fedora-42-xfce_socket-data-duplex: 89.99 🟢 ( previous job: 142.58, improvement: 63.11%)
  • whonix-gateway-17_exec: 7.16 🟢 ( previous job: 8.12, improvement: 88.26%)
  • whonix-gateway-17_exec-root: 38.58 🟢 ( previous job: 41.05, improvement: 93.98%)
  • whonix-gateway-17_socket: 7.37 🟢 ( previous job: 8.52, improvement: 86.46%)
  • whonix-gateway-17_socket-root: 6.73 🟢 ( previous job: 8.12, improvement: 82.90%)
  • whonix-gateway-17_exec-data-simplex: 65.61 🟢 ( previous job: 83.60, improvement: 78.49%)
  • whonix-gateway-17_exec-data-duplex: 66.18 🟢 ( previous job: 68.38, improvement: 96.78%)
  • whonix-gateway-17_exec-data-duplex-root: 76.67 🟢 ( previous job: 99.37, improvement: 77.15%)
  • whonix-gateway-17_socket-data-duplex: 100.41 🟢 ( previous job: 167.12, improvement: 60.08%)
  • whonix-workstation-17_exec: 7.80 🔻 ( previous job: 7.57, degradation: 102.99%)
  • whonix-workstation-17_exec-root: 55.42 🟢 ( previous job: 56.76, improvement: 97.63%)
  • whonix-workstation-17_socket: 8.03 🟢 ( previous job: 8.59, improvement: 93.57%)
  • whonix-workstation-17_socket-root: 7.38 🟢 ( previous job: 8.89, improvement: 82.99%)
  • whonix-workstation-17_exec-data-simplex: 67.38 🔻 ( previous job: 66.80, degradation: 100.86%)
  • whonix-workstation-17_exec-data-duplex: 71.94 🟢 ( previous job: 74.50, improvement: 96.56%)
  • whonix-workstation-17_exec-data-duplex-root: 84.67 🟢 ( previous job: 102.34, improvement: 82.73%)
  • whonix-workstation-17_socket-data-duplex: 100.36 🟢 ( previous job: 147.97, improvement: 67.83%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2268.00 🔻 ( previous job: 2446.00, degradation: 92.72%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11967.00 🟢 ( previous job: 5874.00, improvement: 203.73%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 472.00 🟢 ( previous job: 29.00, improvement: 1627.59%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 399914.00 🟢 ( previous job: 292489.00, improvement: 136.73%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 152193.00 🟢 ( previous job: 110817.00, improvement: 137.34%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 440393.00 🟢 ( previous job: 137802.00, improvement: 319.58%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 176389.00 🟢 ( previous job: 121719.00, improvement: 144.91%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 104513.00 🟢 ( previous job: 103932.00, improvement: 100.56%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6859.00 🟢 ( previous job: 6356.00, improvement: 107.91%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7864.00 🟢 ( previous job: 7695.00, improvement: 102.20%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 5253.00 🟢 ( previous job: 3925.00, improvement: 133.83%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 384234.00 🟢 ( previous job: 366891.00, improvement: 104.73%)
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 178166.00 🟢 ( previous job: 140215.00, improvement: 127.07%)
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 92496.00 🟢 ( previous job: 47575.00, improvement: 194.42%)
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 84052.00 🔻 ( previous job: 86001.00, degradation: 97.73%)
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2855.00 🔻 ( previous job: 3020.00, degradation: 94.54%)
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 395539.00 🟢 ( previous job: 387500.00, improvement: 102.07%)
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 155500.00 🟢 ( previous job: 136640.00, improvement: 113.80%)
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 312169.00 🔻 ( previous job: 325139.00, degradation: 96.01%)
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 90216.00 🟢 ( previous job: 87396.00, improvement: 103.23%)
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 5394.00 🟢 ( previous job: 3765.00, improvement: 143.27%)
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8495.00 🔻 ( previous job: 8992.00, degradation: 94.47%)
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 368309.00 🔻 ( previous job: 383531.00, degradation: 96.03%)
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 152545.00 🔻 ( previous job: 157382.00, degradation: 96.93%)
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 345267.00 🟢 ( previous job: 293225.00, improvement: 117.75%)
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 81030.00 🟢 ( previous job: 64217.00, improvement: 126.18%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 79552.00 🔻 ( previous job: 87141.00, degradation: 91.29%)
  • debian-13-xfce_vm-dispvm (mean:6.609): 79.31
  • debian-13-xfce_vm-dispvm-gui (mean:7.731): 92.77
  • debian-13-xfce_vm-dispvm-concurrent (mean:3.137): 37.65
  • debian-13-xfce_vm-dispvm-gui-concurrent (mean:4.032): 48.39
  • debian-13-xfce_dom0-dispvm (mean:6.97): 83.64
  • debian-13-xfce_dom0-dispvm-gui (mean:8.194): 98.33
  • debian-13-xfce_dom0-dispvm-concurrent (mean:3.392): 40.70
  • debian-13-xfce_dom0-dispvm-gui-concurrent (mean:4.11): 49.33
  • debian-13-xfce_vm-dispvm-preload (mean:2.742): 32.90
  • debian-13-xfce_vm-dispvm-preload-gui (mean:3.701): 44.42
  • debian-13-xfce_vm-dispvm-preload-concurrent (mean:2.585): 31.02
  • debian-13-xfce_vm-dispvm-preload-gui-concurrent (mean:3.388): 40.66
  • debian-13-xfce_dom0-dispvm-preload (mean:3.527): 42.33
  • debian-13-xfce_dom0-dispvm-preload-gui (mean:4.326): 51.92
  • debian-13-xfce_dom0-dispvm-preload-concurrent (mean:2.766): 33.19
  • debian-13-xfce_dom0-dispvm-preload-gui-concurrent (mean:3.893): 46.71
  • debian-13-xfce_dom0-dispvm-api (mean:7.048): 84.58
  • debian-13-xfce_dom0-dispvm-gui-api (mean:8.196): 98.35
  • debian-13-xfce_dom0-dispvm-concurrent-api (mean:3.367): 40.40
  • debian-13-xfce_dom0-dispvm-gui-concurrent-api (mean:4.14): 49.68
  • debian-13-xfce_dom0-dispvm-preload-less-less-api (mean:3.905): 46.87
  • debian-13-xfce_dom0-dispvm-preload-less-api (mean:3.548): 42.58
  • debian-13-xfce_dom0-dispvm-preload-api (mean:3.538): 42.45
  • debian-13-xfce_dom0-dispvm-preload-more-api (mean:3.344): 40.12
  • debian-13-xfce_dom0-dispvm-preload-more-more-api (mean:3.542): 42.51
  • debian-13-xfce_dom0-dispvm-preload-gui-api (mean:4.469): 53.62
  • debian-13-xfce_dom0-dispvm-preload-concurrent-api (mean:2.889): 34.67
  • debian-13-xfce_dom0-dispvm-preload-gui-concurrent-api (mean:3.652): 43.82
  • debian-13-xfce_vm-vm (mean:0.023): 0.28
  • debian-13-xfce_vm-vm-gui (mean:0.028): 0.34
  • debian-13-xfce_vm-vm-concurrent (mean:0.021): 0.25
  • debian-13-xfce_vm-vm-gui-concurrent (mean:0.023): 0.28
  • debian-13-xfce_dom0-vm-api (mean:0.038): 0.46
  • debian-13-xfce_dom0-vm-gui-api (mean:0.034): 0.41
  • debian-13-xfce_dom0-vm-concurrent-api (mean:0.026): 0.31
  • debian-13-xfce_dom0-vm-gui-concurrent-api (mean:0.033): 0.40
  • fedora-42-xfce_vm-dispvm (mean:7.044): 84.53
  • fedora-42-xfce_vm-dispvm-gui (mean:8.323): 99.88
  • fedora-42-xfce_vm-dispvm-concurrent (mean:3.815): 45.78
  • fedora-42-xfce_vm-dispvm-gui-concurrent (mean:4.21): 50.52
  • fedora-42-xfce_dom0-dispvm (mean:7.437): 89.25
  • fedora-42-xfce_dom0-dispvm-gui (mean:8.454): 101.45
  • fedora-42-xfce_dom0-dispvm-concurrent (mean:3.668): 44.02
  • fedora-42-xfce_dom0-dispvm-gui-concurrent (mean:4.562): 54.74
  • fedora-42-xfce_vm-dispvm-preload (mean:3.053): 36.64
  • fedora-42-xfce_vm-dispvm-preload-gui (mean:4.417): 53.01
  • fedora-42-xfce_vm-dispvm-preload-concurrent (mean:2.996): 35.95
  • fedora-42-xfce_vm-dispvm-preload-gui-concurrent (mean:3.472): 41.66
  • fedora-42-xfce_dom0-dispvm-preload (mean:3.777): 45.33
  • fedora-42-xfce_dom0-dispvm-preload-gui (mean:4.934): 59.20
  • fedora-42-xfce_dom0-dispvm-preload-concurrent (mean:3.526): 42.31
  • fedora-42-xfce_dom0-dispvm-preload-gui-concurrent (mean:5.228): 62.74
  • fedora-42-xfce_dom0-dispvm-api (mean:7.63): 91.56
  • fedora-42-xfce_dom0-dispvm-gui-api (mean:8.537): 102.45
  • fedora-42-xfce_dom0-dispvm-concurrent-api (mean:3.691): 44.29
  • fedora-42-xfce_dom0-dispvm-gui-concurrent-api (mean:4.298): 51.57
  • fedora-42-xfce_dom0-dispvm-preload-less-less-api (mean:4.199): 50.38
  • fedora-42-xfce_dom0-dispvm-preload-less-api (mean:4.188): 50.26
  • fedora-42-xfce_dom0-dispvm-preload-api (mean:3.845): 46.14
  • fedora-42-xfce_dom0-dispvm-preload-more-api (mean:3.505): 42.06
  • fedora-42-xfce_dom0-dispvm-preload-more-more-api (mean:3.902): 46.83
  • fedora-42-xfce_dom0-dispvm-preload-gui-api (mean:4.943): 59.31
  • fedora-42-xfce_dom0-dispvm-preload-concurrent-api (mean:3.358): 40.30
  • fedora-42-xfce_dom0-dispvm-preload-gui-concurrent-api (mean:4.041): 48.49
  • fedora-42-xfce_vm-vm (mean:0.033): 0.39
  • fedora-42-xfce_vm-vm-gui (mean:0.027): 0.32
  • fedora-42-xfce_vm-vm-concurrent (mean:0.02): 0.24
  • fedora-42-xfce_vm-vm-gui-concurrent (mean:0.027): 0.33
  • fedora-42-xfce_dom0-vm-api (mean:0.036): 0.43
  • fedora-42-xfce_dom0-vm-gui-api (mean:0.046): 0.55
  • fedora-42-xfce_dom0-vm-concurrent-api (mean:0.03): 0.36
  • fedora-42-xfce_dom0-vm-gui-concurrent-api (mean:0.027): 0.33
  • whonix-workstation-17_vm-dispvm (mean:7.42): 89.04
  • whonix-workstation-17_vm-dispvm-gui (mean:8.33): 99.96
  • whonix-workstation-17_vm-dispvm-concurrent (mean:4.26): 51.12
  • whonix-workstation-17_vm-dispvm-gui-concurrent (mean:4.584): 55.01
  • whonix-workstation-17_dom0-dispvm (mean:8.21): 98.52
  • whonix-workstation-17_dom0-dispvm-gui (mean:9.239): 110.86
  • whonix-workstation-17_dom0-dispvm-concurrent (mean:4.458): 53.50
  • whonix-workstation-17_dom0-dispvm-gui-concurrent (mean:4.786): 57.43
  • whonix-workstation-17_vm-dispvm-preload (mean:3.255): 39.06
  • whonix-workstation-17_vm-dispvm-preload-gui (mean:4.404): 52.84
  • whonix-workstation-17_vm-dispvm-preload-concurrent (mean:3.273): 39.28
  • whonix-workstation-17_vm-dispvm-preload-gui-concurrent (mean:4.087): 49.04
  • whonix-workstation-17_dom0-dispvm-preload (mean:4.061): 48.74
  • whonix-workstation-17_dom0-dispvm-preload-gui (mean:5.386): 64.64
  • whonix-workstation-17_dom0-dispvm-preload-concurrent (mean:3.768): 45.22
  • whonix-workstation-17_dom0-dispvm-preload-gui-concurrent (mean:4.408): 52.90
  • whonix-workstation-17_dom0-dispvm-api (mean:8.517): 102.20
  • whonix-workstation-17_dom0-dispvm-gui-api (mean:9.256): 111.07
  • whonix-workstation-17_dom0-dispvm-concurrent-api (mean:4.112): 49.34
  • whonix-workstation-17_dom0-dispvm-gui-concurrent-api (mean:4.56): 54.72
  • whonix-workstation-17_dom0-dispvm-preload-less-less-api (mean:4.651): 55.81
  • whonix-workstation-17_dom0-dispvm-preload-less-api (mean:4.942): 59.31
  • whonix-workstation-17_dom0-dispvm-preload-api (mean:4.239): 50.87
  • whonix-workstation-17_dom0-dispvm-preload-more-api (mean:4.395): 52.74
  • whonix-workstation-17_dom0-dispvm-preload-gui-api (mean:5.245): 62.94
  • whonix-workstation-17_dom0-dispvm-preload-concurrent-api (mean:3.77): 45.24
  • whonix-workstation-17_dom0-dispvm-preload-gui-concurrent-api (mean:4.418): 53.02
  • whonix-workstation-17_vm-vm (mean:0.032): 0.39
  • whonix-workstation-17_vm-vm-gui (mean:0.029): 0.34
  • whonix-workstation-17_vm-vm-concurrent (mean:0.024): 0.28
  • whonix-workstation-17_vm-vm-gui-concurrent (mean:0.03): 0.36
  • whonix-workstation-17_dom0-vm-api (mean:0.038): 0.46
  • whonix-workstation-17_dom0-vm-gui-api (mean:0.038): 0.46
  • whonix-workstation-17_dom0-vm-concurrent-api (mean:0.025): 0.30
  • whonix-workstation-17_dom0-vm-gui-concurrent-api (mean:0.031): 0.38

This was referenced Oct 3, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Draft
Merged
Merged
Merged
Merged
Merged
@marmarek
Copy link
Member

marmarek commented Oct 3, 2025

This still fails:

Oct 03 09:50:19.316087 dom0 qubesd[7230]: INFO: vm.whonix-workstation-17: Processing pending menu removals
Oct 03 09:50:19.317174 dom0 qubesd[7230]: INFO: Removing appmenus for '' in 'whonix-workstation-17'
...
Oct 03 09:50:21.786535 dom0 qubesd[7230]: Traceback (most recent call last):
Oct 03 09:50:21.786535 dom0 qubesd[7230]:   File "/usr/lib/python3.13/site-packages/qubes/api/__init__.py", line 339, in respond
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     response = await self.mgmt.execute(
Oct 03 09:50:21.786535 dom0 qubesd[7230]:                ^^^^^^^^^^^^^^^^^^^^^^^^
Oct 03 09:50:21.786535 dom0 qubesd[7230]:         untrusted_payload=untrusted_payload
Oct 03 09:50:21.786535 dom0 qubesd[7230]:         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     )
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     ^
Oct 03 09:50:21.786535 dom0 qubesd[7230]:   File "/usr/lib/python3.13/site-packages/qubes/api/admin.py", line 958, in vm_start
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     await self.dest.start()
Oct 03 09:50:21.786535 dom0 qubesd[7230]:   File "/usr/lib/python3.13/site-packages/qubes/vm/qubesvm.py", line 1551, in start
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     await self.fire_event_async(
Oct 03 09:50:21.786535 dom0 qubesd[7230]:         "domain-start", start_guid=start_guid
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     )
Oct 03 09:50:21.786535 dom0 qubesd[7230]:   File "/usr/lib/python3.13/site-packages/qubes/events.py", line 243, in fire_event_async
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     effect = task.result()
Oct 03 09:50:21.786535 dom0 qubesd[7230]:   File "/usr/lib/python3.13/site-packages/qubesappmenusext/__init__.py", line 238, in on_domain_start
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     del vm.features['menu-remove-pending-for']
Oct 03 09:50:21.786535 dom0 qubesd[7230]:         ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
Oct 03 09:50:21.786535 dom0 qubesd[7230]:   File "/usr/lib/python3.13/site-packages/qubes/features.py", line 56, in __delitem__
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     super().__delitem__(key)
Oct 03 09:50:21.786535 dom0 qubesd[7230]:     ~~~~~~~~~~~~~~~~~~~^^^^^
Oct 03 09:50:21.786535 dom0 qubesd[7230]: KeyError: 'menu-remove-pending-for'

''.split(' ') produces a list with a single empty string, not an empty list. ''.split() will discard empty elements, so it should produce empty list

@ben-grande
Copy link
Author

ben-grande commented Oct 3, 2025

''.split(' ') produces a list with a single empty string, not an empty list. ''.split() will discard empty elements, so it should produce empty list

ew:

>>> ''.split()
[]
>>> ''.split(' ')
['']

This was referenced Oct 10, 2025
Merged
Merged
Merged
This was referenced Oct 10, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@marmarek marmarek merged commit 908ae5b into QubesOS:main Oct 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marmarek marmarek marmarek approved these changes

Assignees

No one assigned

Labels

openqa-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ben-grande @qubesos-bot @marmarek