-
-
Notifications
You must be signed in to change notification settings - Fork 74
Add Application search to qube settings #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d019981 to
4686eca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 69.17% 69.34% +0.16%
==========================================
Files 17 17
Lines 3913 3940 +27
==========================================
+ Hits 2707 2732 +25
- Misses 1206 1208 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4686eca to
d8b2d83
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025101005-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests17 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 83 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:166 tests
|
| self.app_list_manager.has_missing | ||
| ) | ||
|
|
||
| def filter_apps(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem with this approach is that if someone searches for "xfce terminal" or "terminal xfce" they won't find either. I think we should find things matching every word in the search query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done. It works on both "xfce terminal" and "terminal xfce" now. Unfortunately we missed the merge window :/
|
|
||
| @check_errors | ||
| @pytest.mark.parametrize("settings_fixture", ["test-red"], indirect=True) | ||
| def test_507_filter_apps(settings_fixture): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but I'd like also tests for two words with two spaces between and two words in reverse order (as mentioned above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also done. I also added leading and trailing spaces
49916c7 to
cebae6a
Compare
cebae6a to
48802ec
Compare
resolves: QubesOS/qubes-issues#10276