Feature ps2 dance mat#17
Open
Official12345 wants to merge 8 commits into
Open
Conversation
streefje1996
requested changes
Aug 28, 2019
streefje1996
left a comment
streefje1996
left a comment
There was a problem hiding this comment.
- Missing doxygen comments
- does the ps2 mat have the same interface as a ps2 controller, maybe you could change it to an ps2 controller interface that supports both controller and mat
streefje1996
requested changes
Aug 28, 2019
streefje1996
left a comment
streefje1996
left a comment
There was a problem hiding this comment.
- tabs on the doxygen code is not aligned well
- missing r2d2 namespace
- build errors
|
|
||
| #include <hwlib.hpp> | ||
| #include <array> | ||
| /* |
| public: | ||
| /* | ||
| * Constructor of the ps2 bus. | ||
| * @param attention |
| /* | ||
| *Struct that contains the states of all buttons. | ||
| */ | ||
| struct button_states_s { |
|
|
||
| auto test = r2d2::manual_control::steering_wheel_controller_c( | ||
| 1, button1, button2, button3, button4, wheel, pedals); | ||
| //const uint8_t poll_command[8] = {0x01, 0x42, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; |
| r2d2::manual_control::module_c controller(comm, test); | ||
| ps2_bus_c bus(ss, sclk, miso, mosi, ack); | ||
| ps2_controller_c controller(bus); | ||
| //std::array<uint8_t, 9> data = mat.read_write(poll_command, 8); |
streefje1996
approved these changes
Aug 29, 2019
streefje1996
left a comment
streefje1996
left a comment
There was a problem hiding this comment.
it might be worth/preference to put an extra tab on comments so they align with the variables/functions.
code looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
working dance mat controller