Skip to content

Bump gfx1250 hotswap integration submodules#6346

Open
harsh-amd wants to merge 8 commits into
ROCm:mainfrom
harsh-amd:therock-gfx1250-hotswap-stack-20260705
Open

Bump gfx1250 hotswap integration submodules#6346
harsh-amd wants to merge 8 commits into
ROCm:mainfrom
harsh-amd:therock-gfx1250-hotswap-stack-20260705

Conversation

@harsh-amd

Copy link
Copy Markdown

Summary

Notes

The submodule integration commits are pushed to:

Testing

  • Not run yet. Next step: build a TheRock tarball on mi300 from this PR branch.

@therock-pr-bot

therock-pr-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@marbre marbre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for testing? As the submodule bumps point to commits not yet merged to main/develop on user branches, this cannot go into main @ TheRock. Please mark is as draft PR or for pure testing, consider triggering a workflow run manually instead of sending a PR.

@ronlieb

ronlieb commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Is this for testing? As the submodule bumps point to commits not yet merged to main/develop on user branches, this cannot go into main @ TheRock. Please mark is as draft PR or for pure testing, consider triggering a workflow run manually instead of sending a PR.

@harsh-amd do you have a PR up on amd-staging for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

3 participants