Skip to content

Bump gfx1250 hotswap integration submodules #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsh-amd wants to merge 8 commits into
base: main
Choose a base branch
from
+22 −2
Open

Bump gfx1250 hotswap integration submodules #6346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca2dd8e
Bump hotswap gfx1250 integration submodules
harsh-amd Jul 5, 2026
414931d
Bump amd-llvm for COMGR hotswap include compatibility
harsh-amd Jul 5, 2026
a40aa27
Export bundled sqlite include path
harsh-amd Jul 5, 2026
ac84b79
Bump amd-llvm for COMGR hotswap sled scoping
harsh-amd Jul 5, 2026
4885965
Use bundled OpenMP for rocBLAS clients
harsh-amd Jul 5, 2026
7b68b7f
Use bundled OpenMP for sparse clients
harsh-amd Jul 5, 2026
4d8424a
Use bundled OpenMP for BLAS clients
harsh-amd Jul 5, 2026
706a8a9
Limit OpenMP config hints to BLAS clients
harsh-amd Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/amd-llvm
Open in desktop
Submodule amd-llvm updated 29 files
+1 −0 amd/comgr/CMakeLists.txt
+89 −1 amd/comgr/include/amd_comgr.h.in
+370 −69 amd/comgr/src/comgr-hotswap-b0a0.cpp
+815 −93 amd/comgr/src/comgr-hotswap-elf.cpp
+628 −0 amd/comgr/src/comgr-hotswap-entry-trampoline.cpp
+139 −20 amd/comgr/src/comgr-hotswap-internal.h
+40 −10 amd/comgr/src/comgr-hotswap-llvm.cpp
+165 −86 amd/comgr/src/comgr-hotswap-patch-f32-to-e5m3.cpp
+10 −8 amd/comgr/src/comgr-hotswap-patch-trampoline.cpp
+2 −2 amd/comgr/src/comgr-hotswap-patch-wmma-scale16.cpp
+235 −14 amd/comgr/src/comgr-hotswap.cpp
+1 −0 amd/comgr/src/exportmap.in
+23 −3 amd/comgr/src/hotswap/README.md
+67 −7 amd/comgr/test-lit/comgr-sources/hotswap-rewrite.c
+27 −7 amd/comgr/test-lit/hotswap-cvt-fp8-bytesel.s
+46 −0 amd/comgr/test-lit/hotswap-cvt-pk-fp8-zero-fill-in-function.s
+69 −0 amd/comgr/test-lit/hotswap-cvt-pk-fp8-zero-fill-sled.s
+84 −14 amd/comgr/test-lit/hotswap-cvt-pk-fp8.s
+28 −10 amd/comgr/test-lit/hotswap-cvt-sr-fp8.s
+93 −0 amd/comgr/test-lit/hotswap-kernel-entry-trampoline.s
+74 −0 amd/comgr/test-lit/hotswap-nop-sled-function-scope.s
+12 −5 amd/comgr/test-lit/hotswap-rewrite.c
+5 −5 amd/comgr/test-lit/hotswap-trampoline-addtid.s
+5 −1 amd/comgr/test-lit/hotswap-trampoline-ds-nosled.s
+58 −8 amd/comgr/test-lit/hotswap-trampoline-tensor.s
+1 −0 amd/comgr/test-unit/CMakeLists.txt
+237 −160 amd/comgr/test-unit/HotswapElfTest.cpp
+478 −140 amd/comgr/test-unit/HotswapMCTest.cpp
+266 −0 amd/comgr/test-unit/comgr-test-elf-utils.h
18 changes: 18 additions & 0 deletions math-libs/BLAS/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,19 @@
# here without worrying about build deps.
therock_cmake_subproject_dist_dir(_blas_hack_hip_dir hip-clr)
cmake_path(APPEND _blas_hack_hip_dir lib/llvm OUTPUT_VARIABLE _toolchain_dir)
set(_blas_hip_clang_root_cmake_args)
if(NOT WIN32)
list(APPEND _blas_hip_clang_root_cmake_args
"-DHIP_CLANG_ROOT=${_toolchain_dir}"
)
endif()
set(_blas_openmp_toolchain_cmake_args)
if(NOT WIN32)
list(APPEND _blas_openmp_toolchain_cmake_args
"-DOpenMP_DIR=${_toolchain_dir}/lib/cmake/openmp"
${_blas_hip_clang_root_cmake_args}
)
endif()

# Most libraries need to depend on the profiler, but is conditionally only used
# on Posix.
Expand Down Expand Up @@ -189,6 +202,7 @@ set(rocBLAS_extra_cmake_args)
if(THEROCK_BUILD_TESTING)
list(APPEND rocBLAS_extra_cmake_args -DROCBLAS_CLIENTS_REFERENCE_ILP64=ON)
endif()
list(APPEND rocBLAS_extra_cmake_args ${_blas_openmp_toolchain_cmake_args})

# Disable rocBLAS samples on Windows due to use of deprecated
# <experimental/filesystem> in client_utility.cpp with MSVC.
Expand Down Expand Up @@ -265,6 +279,7 @@ if(THEROCK_ENABLE_SPARSE)
-DBUILD_CLIENTS_TESTS=${THEROCK_BUILD_TESTING}
-DBUILD_CLIENTS_BENCHMARKS=${THEROCK_BUILD_TESTING}
-DBUILD_CLIENTS_SAMPLES=OFF
${_blas_hip_clang_root_cmake_args}
CMAKE_INCLUDES
therock_explicit_finders.cmake
COMPILER_TOOLCHAIN
Expand Down Expand Up @@ -305,6 +320,7 @@ if(THEROCK_ENABLE_SPARSE)
-DBUILD_CLIENTS_TESTS=${THEROCK_BUILD_TESTING}
-DBUILD_CLIENTS_BENCHMARKS=${THEROCK_BUILD_TESTING}
-DBUILD_CLIENTS_SAMPLES=OFF
${_blas_openmp_toolchain_cmake_args}
COMPILER_TOOLCHAIN
amd-hip
BUILD_DEPS
Expand Down Expand Up @@ -351,6 +367,7 @@ if(THEROCK_ENABLE_SPARSE)
-DHIPSPARSELT_ENABLE_SAMPLES=OFF
-DHIPSPARSELT_ENABLE_FETCH=OFF
-DHIPSPARSELT_ENABLE_THEROCK=ON
${_blas_hip_clang_root_cmake_args}
COMPILER_TOOLCHAIN
amd-hip
BUILD_DEPS
Expand Down Expand Up @@ -500,6 +517,7 @@ therock_cmake_subproject_declare(hipBLAS
-DBUILD_CLIENTS_BENCHMARKS=${THEROCK_BUILD_TESTING}
-DBUILD_CLIENTS_SAMPLES=OFF
-DLINK_BLIS=OFF
${_blas_openmp_toolchain_cmake_args}
COMPILER_TOOLCHAIN
amd-hip
BUILD_DEPS
Expand Down
2 changes: 1 addition & 1 deletion rocm-systems
Open in desktop
Submodule rocm-systems updated 5 files
+26 −0 projects/rocr-runtime/rocrtst/suites/functional/hotswap/fixtures/gfx1250_min.s
+125 −32 projects/rocr-runtime/rocrtst/suites/functional/hotswap/hotswap_rewrite_test.cc
+2 −2 projects/rocr-runtime/runtime/docs/data/env_variables.rst
+3 −1 projects/rocr-runtime/runtime/hsa-runtime/core/inc/hotswap.hpp
+5 −3 projects/rocr-runtime/runtime/hsa-runtime/core/runtime/hotswap.cpp
2 changes: 2 additions & 0 deletions third-party/sysdeps/common/sqlite3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ if(NOT CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
"-DSQLITE3_VERSION=${SQLITE3_VERSION}"
INSTALL_DESTINATION
lib/rocm_sysdeps
INTERFACE_INCLUDE_DIRS
lib/rocm_sysdeps/include
INTERFACE_LINK_DIRS
lib/rocm_sysdeps/lib
INTERFACE_PKG_CONFIG_DIRS
Expand Down
Loading