-
Notifications
You must be signed in to change notification settings - Fork 21
Add fet custom pattern #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 623 of [469b72e], We are taking the base geometry for the new emitter port. This could cause layer/port mismatch.
Hi @Nimok15, thanks for reviewing it. I've checked it and, indeed, it is using the base port as reference. I don't think it will have an issue with routing because the destination will move it to an absolute position, and layers are the same for all of them. However, I agree that it's not clean and is better using the right reference for the emitter. Thanks for noticing. By the way, I couldn't see your suggested change in the code itself, but I know what you meant and going to update the branch with a fix. Thanks, |
7167f77 to
ef9746d
Compare
ef9746d to
c7ead1e
Compare
c7ead1e to
284876a
Compare
Add possibility to create any patter with an array of fets and do an automatic routing.
Based on custom patterning implemented for #50
Note: If required we can remove commits from BJT just to enclose for custom pattern