Skip to content

Conversation

@LuighiV
Copy link
Contributor

@LuighiV LuighiV commented Sep 5, 2025

Add possibility to create any patter with an array of fets and do an automatic routing.

Based on custom patterning implemented for #50

Note: If required we can remove commits from BJT just to enclose for custom pattern

@LuighiV LuighiV mentioned this pull request Sep 7, 2025
4 tasks
Copy link

@Nimok15 Nimok15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 623 of [469b72e], We are taking the base geometry for the new emitter port. This could cause layer/port mismatch.

@LuighiV
Copy link
Contributor Author

LuighiV commented Sep 7, 2025

line 623 of [469b72e], We are taking the base geometry for the new emitter port. This could cause layer/port mismatch.

Hi @Nimok15, thanks for reviewing it. I've checked it and, indeed, it is using the base port as reference. I don't think it will have an issue with routing because the destination will move it to an absolute position, and layers are the same for all of them. However, I agree that it's not clean and is better using the right reference for the emitter. Thanks for noticing.

By the way, I couldn't see your suggested change in the code itself, but I know what you meant and going to update the branch with a fix.

Thanks,
Luighi

@LuighiV LuighiV force-pushed the add-fet-custom-pattern branch from 7167f77 to ef9746d Compare September 7, 2025 14:55
@LuighiV LuighiV marked this pull request as ready for review September 7, 2025 14:56
@LuighiV
Copy link
Contributor Author

LuighiV commented Sep 7, 2025

Hi @Nimok15
I think I've added the requested change, can you take a look on it please?
As this PR is built on PR #50 I've added the correction to both.

Thanks,
Luighi

@Nimok15
Copy link

Nimok15 commented Sep 7, 2025

Hi @LuighiV, thanks for updating it. I will review #50 and get back to you.

Thanks,
Nimish

@LuighiV LuighiV force-pushed the add-fet-custom-pattern branch from ef9746d to c7ead1e Compare September 9, 2025 04:35
@LuighiV LuighiV mentioned this pull request Sep 18, 2025
5 tasks
@LuighiV LuighiV force-pushed the add-fet-custom-pattern branch from c7ead1e to 284876a Compare November 6, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants