Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP requirement and CI setup to test against PHP 8.3 #43

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Update PHP requirement and CI setup to test against PHP 8.3 #43

merged 2 commits into from
Apr 9, 2024

Conversation

javespi
Copy link
Contributor

@javespi javespi commented Apr 9, 2024

@Ocramius Ocramius added this to the 2.4.0 milestone Apr 9, 2024
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javespi

"behat/behat": "^3.11.0",
"psr/container": "^1.1.2",
"symfony/config": "^6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unit tests in php 8.2 and 8.3 were failing because in QA Checks latest jobs symfony/config 7.0 is upgraded which looks like a BC is introduced:

1) RoaveTest\BehatPsrContainer\PsrContainerExtensionTest::testConfiguration
TypeError: Symfony\Component\Config\Definition\Builder\NodeDefinition::end(): Return value must be of type Symfony\Component\Config\Definition\Builder\NodeParentInterface, null returned

I required symfony/config ^6.0 which I think it makes sense because symfony config component is being used in:

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;

I was writing if this fix makes sense but you was faster! 🔥

Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now: I think this is a job for maglnet/composer-require-checker, if it happens again

@Ocramius Ocramius self-assigned this Apr 9, 2024
@Ocramius Ocramius merged commit 4bf9198 into Roave:2.4.x Apr 9, 2024
23 checks passed
@javespi javespi deleted the allow-php83 branch April 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants