Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP requirement and CI setup to test against PHP 8.3 #43

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Update PHP requirement and CI setup to test against PHP 8.3 #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d51ea7
Update PHP requirement and CI setup to test against PHP 8.3
javespi Apr 9, 2024
0b105d4
Require symfony/config ^6.0
javespi Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
operating-system:
- "ubuntu-latest"

Expand Down
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
"description": "PSR-11 Container extension for Behat",
"type": "library",
"require": {
"php": "~8.0.0 || ~8.1.0 || ~8.2.0",
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
"behat/behat": "^3.11.0",
"psr/container": "^1.1.2",
"symfony/config": "^6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This was indeed used in the PsrContainerExtension, but never declared!

https://github.com/Roave/behat-psr11extension/blob/7155882d46c0ad8e70bc2baa01299f178d763bb6/src/PsrContainerExtension.php#L10C5-L10C29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unit tests in php 8.2 and 8.3 were failing because in QA Checks latest jobs symfony/config 7.0 is upgraded which looks like a BC is introduced:

1) RoaveTest\BehatPsrContainer\PsrContainerExtensionTest::testConfiguration
TypeError: Symfony\Component\Config\Definition\Builder\NodeDefinition::end(): Return value must be of type Symfony\Component\Config\Definition\Builder\NodeParentInterface, null returned

I required symfony/config ^6.0 which I think it makes sense because symfony config component is being used in:

behat-psr11extension/src/PsrContainerExtension.php

Line 10 in 7155882

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;

I was writing if this fix makes sense but you was faster! 🔥

Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now: I think this is a job for maglnet/composer-require-checker, if it happens again

"symfony/dependency-injection": "^6.0.13"
},
"require-dev": {
Expand Down
4 changes: 2 additions & 2 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading