Fix KeyError in ROS2 ActionClient when receiving action results from rosbridge #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the KeyError that occurred when ROS2 ActionClient received action results from rosbridge. The issue was caused by the code attempting to access
message["status"]
without checking if the field existed or handling different message formats.Changes
_handle_action_result()
to handle multiple message formats (status at top level or inside values)Testing
✅ All 4 new tests pass
✅ All existing unit tests still pass
✅ All linters pass (flake8, black, isort)
Impact
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.