ROS2 frame tests #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 28, 2023 15:44
Signed-off-by: Adam Krawczyk <[email protected]>
Signed-off-by: Adam Krawczyk <[email protected]>
Signed-off-by: Adam Krawczyk <[email protected]>
pijaro
reviewed
May 4, 2023
|
|
||
| - Run the game (`ctrl + G`) | ||
|
|
||
| - Check the `tf_static` by running the command `ros2 topic echo /tf_static` This should print the transform between the two frames. Move the camera (WASD) and check if the transform is updated. |
There was a problem hiding this comment.
What is the purpose of moving the camera at this point? Is there any frame attached to the camera?
| from azlmbr.entity import EntityType | ||
|
|
||
| import subprocess | ||
| DEGREE_RADIAN_FACTOR = 0.0174533 |
There was a problem hiding this comment.
Convert deg to rad with math.radians()
|
|
||
| if __name__ == "__main__": | ||
|
|
||
| typeNameList = ["ROS2 Camera Sensor", "ROS2 Frame"] |
There was a problem hiding this comment.
Inconsistent naming convention. Use lower_camel_case for temp variables as previously.
|
|
||
| ## ROS2 Checking if the transform is correct | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare tests for ROS2 frame component