Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Typescript support for Adaptation Project #2812

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Jan 22, 2025

Feat for #2811.

  • Enhances the generate method for creating an Adaptation Project by dynamically including needed files, and npm packages that are needed for the project to support typescript.
  • Enhances the route handler for controller extension creation to write TypeScript controller extension template. It also enhances the data retrieval for the existing controller extension.
  • Enhances the preview-middleware-client controller extension dialog to show file extension dynamically depending on TypeScript support.
  • Added cross-env for test scripts. cross-env ensures FIORI_TOOLS_DISABLE_SECURE_STORE=true is properly set on all platforms (Windows, macOS, Linux). Jest will no longer misinterpret it as a test file pattern.

@nikmace nikmace added feature New feature or request adp-tooling labels Jan 22, 2025
@nikmace nikmace self-assigned this Jan 22, 2025
@nikmace nikmace requested a review from a team as a code owner January 22, 2025 14:40
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 5216260

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sap-ux-private/preview-middleware-client Minor
@sap-ux/adp-tooling Minor
@sap-ux/create Minor
@sap-ux/preview-middleware Minor
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace requested a review from a team as a code owner January 27, 2025 07:26
testojs
testojs previously approved these changes Feb 14, 2025
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code looks good
  • changeset OK
  • excellent test coverage
  • did not tested manually

@nikmace nikmace requested a review from a team as a code owner February 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants