Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: introduce constant package to handle UI5 default version #721

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Aug 9, 2024

Introduction
Use of DEFAULT_UI5_VERSION and similar constants were wide spread in different packages. Adaption was not easy. This PR introduces constant package. These constant are used across other packages. Constant package is dependent free therefore it avoids cyclic dependency

PR contains

  • new package "@ui5-language-assistant/constant"
  • cleanup and new unit tests

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 58346ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-validation Patch
@ui5-language-assistant/xml-views-tooltip Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/test-utils Patch
@ui5-language-assistant/semantic-model Patch
@ui5-language-assistant/semantic-model-types Patch
@ui5-language-assistant/logic-utils Patch
@ui5-language-assistant/constant Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/xml-views-quick-fix Patch
@ui5-language-assistant/xml-views-definition Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marufrasully marufrasully changed the title fix: introduce constant package to handle UI5 default version in cent… fix: introduce constant package to handle UI5 default version Aug 9, 2024
Copy link

@marufrasully marufrasully merged commit b2a8d01 into master Aug 12, 2024
9 checks passed
@marufrasully marufrasully deleted the fix/default-ui5-version branch August 12, 2024 14:05
@marufrasully marufrasully mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants