Move PMTBeamSignal data product from icaruscode to sbnobj #832
Conversation
mvicenzi
left a comment
mvicenzi
left a comment
There was a problem hiding this comment.
This looks pretty straighforward, but I have just two minor comments below.
This reverts commit ffbcc35.
aheggest
moved this from Open pull requests
to PR in progress
in SBN software development
mvicenzi
left a comment
mvicenzi
left a comment
There was a problem hiding this comment.
Few more comments on the recent additions.
The most important is making the namespace converter more general to be able to handle both RWM and EW products. There is no current need for it, but you never know.
|
trigger build larsoft@v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnobj#130 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_09_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
This pull request (together with sbnobj PR #130) moves the PMTBeamSignal data product from
icaruscode/IcarusObjto a SBN common area,sbnobj/Common. This enables the special RWM signals digitized by the PMTs to be read into the CAFs.The main changes in this PR are switching all
icarus::timing::PMTBeamSignal-->sbn::timing::PMTBeamSignaland removing the previous defintion in PMTBeamSignal.h.This PR is a part of a PR pair:
To fully get the information into the CAFs, sbncode PR#541 and sbnanaobj PR#141 should also be merged in, but this icaruscode PR #832 and sbnobj PR #130 do not rely on sbncode PR#541 and sbnanaobj PR#141.
Added a simple producer module PMTBeamSignalNameSpaceConverter_module.cc to convert the PMTBeamSignal from
icarus::timingnamespace tosbn::timing. This is to help with backward compatibility for files that were produced withicarus::timing::PMTBeamSignal- we can convert the data product to the correctsbn::timingnamespace needed to be read into the CAFs.