Add PMT Beam Signal timing to ICARUS CAFs #541
Conversation
…using information stored in PMTBeamSignal
mvicenzi
left a comment
mvicenzi
left a comment
There was a problem hiding this comment.
Generally looks good. Main comment is: we need to make sure this doesn't break if the product is missing (MC files, older data files). Have you tested this as well?
mvicenzi
left a comment
mvicenzi
left a comment
There was a problem hiding this comment.
My comments were addressed by the recent changes, so I approve.
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnobj#130 SBNSoftware/sbnanaobj#141 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnobj#130 SBNSoftware/sbnanaobj#141 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
Description
This pull request reads the special PMT Beam timing signal (RWM) into the CAFMaker which enables us to reconstruct the Beam Bunch structure seen by ICARUS PMTs.
The PMT Beam signals were originally stored in an icaruscode data product
icarus::timing::PMTBeamSignal, but icaruscode PR #832 and sbnobj PR #130 together move the data product to a SBN common area,sbnobj/Common.A
std::vector<sbn::timing::PMTBeamSignal>is read into the CAFMaker and then passed toFillICARUSOpFlashif thePMTBeamSignalis valid. If running on MC, offbeam data or stage1 files without thesbn::timing::PMTBeamSignaldata product, thesrflash.rwmtimevariable will be left to it's default valuekSignalingNaNin SROpFlash.h.Within
FillICARUSOpFlash, two new helper functions defined in sbnobj/Common/PMT/Data/PMTBeamSignal.cxx are called.SelectFirstOpHitByTimereads in a single OpHit and returns a startmap and risemap (holding the start and rise time of each OpHit channel).getFlashBunchTimereads in the risemap andstd::vector<sbn::timing::PMTBeamSignal> RWMTimes, finds the mean between the first OpHit RiseTimes on opposite walls to get the Flash Interaction time wrt the RWM time.This PR is a companion to sbnanaobj PR #141. This PR requires icaruscode PR #832 and sbnobj PR #130 also being merged.