pool hook test + fix TradePanel DOM leak + explicit test paths#281
Merged
IbrahimIjai merged 2 commits intoJun 26, 2026
Merged
Conversation
|
@Chidubemkingsley is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Chidubemkingsley Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of what's been done
Branch: Web-trade-trade-panel-default-render (5 commits ahead of main)
What was built
Hook data integrity (all Soroban calls succeed, disconnected → 0n, partial failures → nulls)
Derived fields (TVL, estimated APY, null APY fallback, open interest USD, null OI fallback, funding rate % hour, null funding fallback, 50/50 composition, equal composition, token symbols from config)
What was fixed
Added afterEach(cleanup) to TradePanel test (DOM leak between files)
Mocked @/lib/contracts comprehensively in both test files (prevents vi.mock leaks when bun runs files sequentially)
Renamed use-pool-row-data.test.ts → .tsx (contains JSX in createWrapper)
Updated package.json test command to explicitly discover pool/trade test directories (bun 1.3.9 has a bug: src/features/pools/ and src/features/trade/ are not auto-discovered)
Result
bun run --cwd apps/web test → 102 pass, 0 fail, 10 test files, 4.90s
closes Web pools: pool row data hook #223