Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with fast fail to cut 40% of proccessing #6284

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

refack
Copy link

@refack refack commented Feb 10, 2025

Description

Motivation and Context

Speed

How Has This Been Tested?

  1. Step debugger
  2. CLI inteface
  3. tests

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • [] I have updated the documentation accordingly.
  • [] I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@refack refack changed the base branch from master to develop February 10, 2025 23:10
@refack
Copy link
Author

refack commented Feb 10, 2025

Since this takes 60% time from current master IMHO we can drop the [System.Text.Json.JsonDocument] shenanigans

@refack
Copy link
Author

refack commented Feb 10, 2025

anecdotal pref (3 buckets - main, extras, versions):

PS C:\bin\tools\scoop\apps\scoop\current> timeit {scoop search proton}
Results from local buckets...
00:00:02.1110227

Name               Version Source Binaries
----               ------- ------ --------
proton-mail-export 1.0.4   extras
protonmail-bridge  3.17.0  extras

PS C:\bin\tools\scoop\apps\scoop\current> git pull
From https://github.com/refack/scoop
 * branch              search-fast-fail -> FETCH_HEAD
Updating ac6f1baa..c60c682c
Fast-forward
 libexec/scoop-search.ps1 | 75 +++---------------------------------------------
 1 file changed, 4 insertions(+), 71 deletions(-)
PS C:\bin\tools\scoop\apps\scoop\current> timeit {scoop search proton}
Results from local buckets...
00:00:01.3423720

Name               Version Source Binaries
----               ------- ------ --------
proton-mail-export 1.0.4   extras
protonmail-bridge  3.17.0  extras

PS C:\bin\tools\scoop\apps\scoop\current>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant