Skip to content

[RN]: use published artifacts for RN native builds/tests#227

Merged
kieran-osgood-shopify merged 2 commits into
mainfrom
kieran-osgood/release-workflow/rn-native-sdk-versions
May 29, 2026
Merged

[RN]: use published artifacts for RN native builds/tests#227
kieran-osgood-shopify merged 2 commits into
mainfrom
kieran-osgood/release-workflow/rn-native-sdk-versions

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 28, 2026

Why

Last week we published version 4.0.0-alpha.1 under the new namespace
With this, we have a version that we can statically point to in our configs, removing the need to have --local runs on CI, which integrates/validates against the wrong build artifact for an actual production release

The USE_LOCAL_SDK environment variable and --local flag will still exist for local development but we no longer run them on CI

This safely guards our releases, and brings back the natural flow of:
develop native sdk -> release native sdk -> develop react native sdk -> release react native sdk

Except you also have the ability to test local dev, meaning you can develop react native at the same time, but when it comes to publishing you have to hold off that graphite stack

Other

I also centralised the native SDK version keys the react-native module depends on in the package.json and pull these programmatically at build time in gradle/ruby.

This simplifies maintenance as we only have to manage the package json to update the version now


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 28, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.59% (316/345) 87.25% (178/204) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/release-workflow/react-native-publish to graphite-base/227 May 28, 2026 12:41
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 52e5847 to 700a4a1 Compare May 28, 2026 12:41
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/227 to main May 28, 2026 12:41
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 28, 2026 12:45
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 28, 2026 12:45
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 700a4a1 to 6601e20 Compare May 28, 2026 12:45
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as draft May 28, 2026 12:56
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 6601e20 to 6490780 Compare May 28, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 6490780 to 39316f7 Compare May 28, 2026 13:31
@kieran-osgood-shopify kieran-osgood-shopify changed the title chore: centralize RN native SDK versions Refactor CI to use Published artifacts for RN native builds/tests May 28, 2026
@kieran-osgood-shopify kieran-osgood-shopify changed the title Refactor CI to use Published artifacts for RN native builds/tests [RN][CI]: use published artifacts for RN native builds/tests May 28, 2026
@kieran-osgood-shopify kieran-osgood-shopify changed the title [RN][CI]: use published artifacts for RN native builds/tests [RN]: use published artifacts for RN native builds/tests May 28, 2026
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 28, 2026 14:06
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 023cd15 to 7dc139f Compare May 29, 2026 08:07
}


def useLocalSdk = (System.getenv("USE_LOCAL_SDK") ?: "0") == "1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding this to dev.yml commands?

Probably the best default to use for local dev?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is part of the dev.yml commands

image.png

dev rn android --local will give you local maven

By default I think local being false is safer and less confusing
Most react-native code will want writing/integrating against the released maven/cocoapods to match local with CI

The --local flag is an opt in to the workflow of "I'm working on a swift/android change and I want to test in react-native before releasing" e.g. what we did with prototype/development and during this migration
I don't think this is the default case though, and can be slightly more confusing / trip people up

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good

Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 29, 2026

Merge activity

@kieran-osgood-shopify kieran-osgood-shopify merged commit 6bdcc79 into main May 29, 2026
20 checks passed
@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/release-workflow/rn-native-sdk-versions branch May 29, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants