Skip to content

fix: remove USE_LOCAL_SDK from CI runs#228

Closed
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/release-workflow/rn-native-sdk-versionsfrom
kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns
Closed

fix: remove USE_LOCAL_SDK from CI runs#228
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/release-workflow/rn-native-sdk-versionsfrom
kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 28, 2026

What changes are you making?

Last week we published version 4.0.0-alpha.1 under the new namespace
With this, we have a version that we can statically point to in our configs, removing the need to have --local runs on CI.
The USE_LOCAL_SDK environment variable and --local flag will still exist for local development but we no longer run them on CI

This safely guards our releases, and brings back the natural flow of:
develop native sdk -> release native sdk -> develop react native sdk -> release react native sdk
Except you also have the ability to test local dev, meaning you can develop react native at the same time, but when it comes to publishing you have to hold off that graphite stack


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 28, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.59% (316/345) 87.25% (178/204) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 28, 2026 12:34
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 28, 2026 12:34
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/release-workflow/rn-native-sdk-versions to graphite-base/228 May 28, 2026 12:41
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns branch from 7450ad3 to 06c3e33 Compare May 28, 2026 12:41
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/228 to kieran-osgood/release-workflow/react-native-publish May 28, 2026 12:41
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/react-native-publish branch from 3cea7db to fc790ec Compare May 28, 2026 12:45
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns branch from 06c3e33 to 2c1d798 Compare May 28, 2026 12:46
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/release-workflow/react-native-publish to graphite-base/228 May 28, 2026 12:49
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns branch from 2c1d798 to 1f13cd8 Compare May 28, 2026 12:49
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/228 to kieran-osgood/release-workflow/rn-native-sdk-versions May 28, 2026 12:49
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as draft May 28, 2026 12:56
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 6601e20 to 6490780 Compare May 28, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns branch from 1f13cd8 to 1338551 Compare May 28, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 6490780 to 39316f7 Compare May 28, 2026 13:31
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns branch from 1338551 to 023cd15 Compare May 28, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant