Skip to content

fix: remove USE_LOCAL_SDK from CI runs #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kieran-osgood-shopify wants to merge 1 commit into from
Closed

fix: remove USE_LOCAL_SDK from CI runs #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/rn-build-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ permissions:

env:
JAVA_VERSION: '22'
# TODO: remove once ShopifyCheckoutKit is published to CocoaPods trunk and
# Maven Central. Tracks the new pod/AAR name introduced by the
# ShopifyCheckoutSheetKit → ShopifyCheckoutKit rename.
USE_LOCAL_SDK: "1"

jobs:
build-android:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/rn-build-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ on:
permissions:
contents: read

# TODO: remove once ShopifyCheckoutKit is published to CocoaPods trunk and
# Maven Central. Tracks the new pod/AAR name introduced by the
# ShopifyCheckoutSheetKit → ShopifyCheckoutKit rename.
env:
USE_LOCAL_SDK: "1"

jobs:
build-ios:
name: Build iOS Sample
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/rn-check-packed-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ on:
permissions:
contents: read

# TODO: remove once ShopifyCheckoutKit is published to CocoaPods trunk and
# Maven Central. Tracks the new pod/AAR name introduced by the
# ShopifyCheckoutSheetKit → ShopifyCheckoutKit rename.
env:
USE_LOCAL_SDK: "1"

jobs:
check-packed-files:
name: Check package files
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/rn-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ on:
permissions:
contents: read

# TODO: remove once ShopifyCheckoutKit is published to CocoaPods trunk and
# Maven Central. Tracks the new pod/AAR name introduced by the
# ShopifyCheckoutSheetKit → ShopifyCheckoutKit rename.
env:
USE_LOCAL_SDK: "1"

jobs:
swiftlint:
name: SwiftLint
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/rn-test-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ permissions:

env:
JAVA_VERSION: '22'
# TODO: remove once ShopifyCheckoutKit is published to CocoaPods trunk and
# Maven Central. Tracks the new pod/AAR name introduced by the
# ShopifyCheckoutSheetKit → ShopifyCheckoutKit rename.
USE_LOCAL_SDK: "1"

jobs:
test-android:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/rn-test-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ on:
permissions:
contents: read

# TODO: remove once ShopifyCheckoutKit is published to CocoaPods trunk and
# Maven Central. Tracks the new pod/AAR name introduced by the
# ShopifyCheckoutSheetKit → ShopifyCheckoutKit rename.
env:
USE_LOCAL_SDK: "1"

jobs:
test-ios:
name: Run iOS Tests
Expand Down
2 changes: 1 addition & 1 deletion platforms/react-native/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ USE_LOCAL_SDK=1 dev rn android

### CI

CI uses the default (published) path naturally — no special flag handling. As defense-in-depth, the build wiring still ignores `USE_LOCAL_SDK=1` when the `CI` env var is set (GitHub Actions sets `CI=true` automatically).
CI uses the default (published) path naturally — no special flag handling. Keep `USE_LOCAL_SDK=1` scoped to local development or explicit validation against unreleased native SDK changes.

### Gotchas

Expand Down
Loading