-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vsc build updates #5797
Vsc build updates #5797
Conversation
Co-authored-by: Aaron Casanova <[email protected]>
|
@@ -1,9 +1,10 @@ | |||
.turbo | |||
../** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason the vsce
cli will package up the entire repo with the extension without this. I'm hoping this won't be necessary after @romellogoodman's PR to add rollup as a build tool #5802
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be helpful to include a comment here since it's resolving a specific edge case. I don't know the ignore pattern off the top, but we could also try to make this self documenting with a negated pattern e.g. ignore everything that's not polaris-for-vscode
../**
!../polaris-for-vscode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some digging here and seems like there still ins't official support for vsce package
for yarn workspaces
This should be a problem if we are bundling node_modules
with the package using webpack or rollup (I think) according to this comment
WHY are these changes introduced?
vsce package
WHAT is this pull request doing?
.vscodeignore
to exclude everything outside ofpolaris-for-vscode
and.turbo
v0.2.0
main