Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vsc build updates #5797

Merged
merged 10 commits into from
May 16, 2022
Merged

Vsc build updates #5797

merged 10 commits into from
May 16, 2022

Conversation

yurm04
Copy link
Contributor

@yurm04 yurm04 commented May 12, 2022

WHY are these changes introduced?

  • The entire monorepo was getting packaged up with the extension on vsce package
  • Get ready for v0.2.0
  • Bring up to speed with main

WHAT is this pull request doing?

  • updating the .vscodeignore to exclude everything outside of polaris-for-vscode and .turbo
  • bump the version to v0.2.0
  • merge main

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

⚠️ No Changeset found

Latest commit: cf78bf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,9 +1,10 @@
.turbo
../**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the vsce cli will package up the entire repo with the extension without this. I'm hoping this won't be necessary after @romellogoodman's PR to add rollup as a build tool #5802

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to include a comment here since it's resolving a specific edge case. I don't know the ignore pattern off the top, but we could also try to make this self documenting with a negated pattern e.g. ignore everything that's not polaris-for-vscode

../**
!../polaris-for-vscode

Copy link
Member

@sam-b-rose sam-b-rose May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some digging here and seems like there still ins't official support for vsce package for yarn workspaces

This should be a problem if we are bundling node_modules with the package using webpack or rollup (I think) according to this comment

@yurm04 yurm04 merged commit 424e6a0 into main May 16, 2022
@yurm04 yurm04 deleted the vsc-build-updates branch May 16, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants