Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vsc build updates #5797

Merged
merged 10 commits into from
May 16, 2022
Merged

Vsc build updates #5797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3dd029
update changelog and bump version number
yurm04 May 12, 2022
6fc99b2
updated date
yurm04 May 12, 2022
074b03d
Update polaris-for-vscode/CHANGELOG.md
May 12, 2022
c0169a5
bumping version
yurm04 May 12, 2022
b4d3859
update vscodeignore to stop bundling entire monorepo with extension
yurm04 May 12, 2022
a3c8572
Merge branch 'main' of https://github.com/Shopify/polaris into vsc-bu…
yurm04 May 13, 2022
da1e2a0
update ignore
yurm04 May 13, 2022
5eb3934
change date on changelog
yurm04 May 13, 2022
5dd372e
Merge branch 'main' of https://github.com/Shopify/polaris into vsc-bu…
yurm04 May 16, 2022
cf78bf2
update date
yurm04 May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion polaris-for-vscode/.vscodeignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
.turbo
../**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the vsce cli will package up the entire repo with the extension without this. I'm hoping this won't be necessary after @romellogoodman's PR to add rollup as a build tool #5802

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to include a comment here since it's resolving a specific edge case. I don't know the ignore pattern off the top, but we could also try to make this self documenting with a negated pattern e.g. ignore everything that's not polaris-for-vscode

../**
!../polaris-for-vscode

Copy link
Member

@sam-b-rose sam-b-rose May 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some digging here and seems like there still ins't official support for vsce package for yarn workspaces

This should be a problem if we are bundling node_modules with the package using webpack or rollup (I think) according to this comment

**/tsconfig.json
**/*.map
**/*.ts
*.vsix
CONTRIBUTING.md
docs
scripts
src
node_modules
5 changes: 3 additions & 2 deletions polaris-for-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ The format is based on [these versioning and changelog guidelines](/documentatio

---

## `v0.2.0` 2022-04-12
## `v0.2.0` - 2022-05-16

- Removed `var()` autocomplete and added `--p-` prefix to completion item label ([#5764](https://github.com/Shopify/polaris/pull/5764))
- Added token documentation to completion items ([#5789](https://github.com/Shopify/polaris/pull/5789))

## `v0.1.0` 2022-04-12
## `v0.1.0` - 2022-04-12

- Initial release
2 changes: 1 addition & 1 deletion polaris-for-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"bugs": {
"url": "https://github.com/Shopify/polaris/issues"
},
"version": "0.1.1",
"version": "0.2.0",
"keywords": [
"polaris",
"shopify"
Expand Down