use @shopify/eslint-plugin#31
Merged
Merged
Conversation
| // Allow inline comments | ||
| 'line-comment-position': 'off', | ||
| // Allow buildSchema (not just buildClientSchema) | ||
| '@shopify/typescript-prefer-build-client-schema': 'off', |
Contributor
There was a problem hiding this comment.
This is good but no-undef and un-unassigned-vars could also be good additions.
saga-dasgupta
approved these changes
Oct 29, 2025
andrewhassan
approved these changes
Oct 29, 2025
| { | ||
| rules: { | ||
| // Relax some rules for a library project | ||
| '@typescript-eslint/no-explicit-any': 'warn', |
There was a problem hiding this comment.
Are there uses of any in here? We generally should try not to use that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds @shopify/eslint-plugin to standardize formatting and linting.
Since there are other PRs in flight, I chose to not apply the changes to the actual files yet.
I can do that in a later PR and hook it into CI at that time.