Skip to content

use @shopify/eslint-plugin #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lopert merged 2 commits into from
Oct 29, 2025
Merged

use @shopify/eslint-plugin #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd9be84
use @shopify/eslint-plugin
lopert Oct 28, 2025
1496a99
remove rule that allows `any`
lopert Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .eslintrc.js
View file
Open in desktop

This file was deleted.

21 changes: 21 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import shopifyPlugin from '@shopify/eslint-plugin';

export default [
{
ignores: ['dist/**', 'node_modules/**', 'test-app/**'],
},
...shopifyPlugin.configs.typescript,
...shopifyPlugin.configs.prettier,
{
rules: {
// This library doesn't use component boundaries
'@shopify/strict-component-boundaries': 'off',
// Allow file extensions in imports (standard for ES modules)
'import-x/extensions': 'off',
// Allow inline comments
'line-comment-position': 'off',
// Allow buildSchema (not just buildClientSchema)
'@shopify/typescript-prefer-build-client-schema': 'off',
Copy link
Copy Markdown
Contributor

@saga-dasgupta saga-dasgupta Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but no-undef and un-unassigned-vars could also be good additions.

},
},
];
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,12 @@
"graphql": "^16.11.0"
},
"devDependencies": {
"@shopify/eslint-plugin": "^50.0.0",
"@types/node": "^22.18.6",
"eslint": "^8.57.0",
"@typescript-eslint/eslint-plugin": "^8.46.2",
"@typescript-eslint/parser": "^8.46.2",
"eslint": "^9.38.0",
"prettier": "^3.6.2",
"typescript": "^5.6.3",
"vitest": "^3.2.4"
},
Expand Down
Loading