Add standalone reference tests for cellular ODE models - #627
Conversation
|
The Regazzoni reference generator currently uses the authors’ C++ implementation at a pinned commit, so regenerating it requires a local clone of I did consider making it more self-contained, either by optionally fetching the pinned source automatically or by writing an independent Python version similar to the TP06 generator. I also wasn’t sure whether bundling or automatically fetching an external reference implementation is something we want to do in svMultiPhysics, so I didn’t want to make that choice without asking. I’d be happy to change the workflow if you think a more self-contained approach would be preferable. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 72.86% 73.08% +0.22%
==========================================
Files 258 266 +8
Lines 39500 39980 +480
Branches 6730 6797 +67
==========================================
+ Hits 28780 29221 +441
- Misses 10477 10516 +39
Partials 243 243 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Resolves #597.
Current situation
The existing regression tests for cellular ODE models use reference solutions generated by svMultiPhysics itself and are generally coupled to larger 3D problems.
This PR adds standalone unit tests for ionic and active-stress models using independently generated reference trajectories.
Release Notes
IonicModelandActiveStress.tests/unitTests/reference_data/.tests/unitTests/reference_generators/.Testing
Code of Conduct & Contributing Guidelines