[Enhancement] Support overflow mode for decimal type #30419

liuyehcf · 2023-09-05T08:07:06Z

Main work

Support error reporting when decimal overflow by introducing a OverflowMode, which has three different modes:

IGNORE
OUTPUT_NULL
REPORT_ERROR

This behavior can be enabled by setting session varaible set sql_mode='ERROR_IF_OVERFLOW'

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

Signed-off-by: liuyehcf <[email protected]>

fzhedu · 2023-09-11T02:02:09Z

test/sql/test_decimal/R/test_decimal_overflow

+-- !result
+select /*+ SET_VAR(sql_mode='ERROR_IF_OVERFLOW')*/ cast(c_d32 * c_d32 as decimal32) from t_decimal_overflow where c_id = 1;
+-- result:
+E: (1064, 'Expr evaluate meet error: Decimal overflow')


from the error msg, we can't know which expr report this error, can the error specify the operator?

Add more precise information.

Signed-off-by: liuyehcf <[email protected]>

sonarcloud · 2023-09-11T03:11:05Z

SonarCloud Quality Gate failed.

6 Bugs
0 Vulnerabilities
2 Security Hotspots
269 Code Smells

0.0% Coverage
1.2% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

wanpengfei-git · 2023-09-11T07:31:26Z

[FE Incremental Coverage Report]

😍 pass : 3 / 3 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/qe/SessionVariable.java	2	2	100.00%	[]
🔵	com/starrocks/qe/SqlModeHelper.java	1	1	100.00%	[]

wanpengfei-git · 2023-09-11T07:32:07Z

[BE Incremental Coverage Report]

😞 fail : 54 / 112 (48.21%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	src/exprs/expr_context.cpp	0	2	00.00%	[189, 190]
🔵	src/exprs/decimal_binary_function.h	0	17	00.00%	[62, 68, 71, 84, 85, 86, 88, 89, 92, 93, 94, 96, 97, 98, 103, 107, 108]
🔵	src/exprs/function_context.cpp	0	2	00.00%	[159, 160]
🔵	src/runtime/runtime_state.h	0	2	00.00%	[342, 343]
🔵	src/exprs/arithmetic_expr.cpp	0	12	00.00%	[109, 111, 114, 157, 158, 160, 174, 176, 179, 199, 201, 204]
🔵	src/exprs/math_functions.h	0	3	00.00%	[376, 378, 381]
🔵	src/exprs/arithmetic_operation.h	0	6	00.00%	[81, 83, 85, 91, 93, 97]
🔵	src/exprs/cast_expr.cpp	8	16	50.00%	[1086, 1087, 1088, 1091, 1102, 1110, 1118, 1285]
🔵	src/exprs/decimal_cast_expr.h	46	52	88.46%	[75, 94, 112, 212, 319, 366]

wanpengfei-git · 2023-09-11T07:42:06Z

@Mergifyio backport branch-3.1

wanpengfei-git · 2023-09-11T07:42:08Z

@Mergifyio backport branch-3.0

wanpengfei-git · 2023-09-11T07:42:10Z

@Mergifyio backport branch-2.5

mergify · 2023-09-11T07:42:14Z

backport branch-3.1

✅ Backports have been created

#30708 [Enhancement] Support overflow mode for decimal type (backport #30419) has been created for branch branch-3.1 but encountered conflicts

mergify · 2023-09-11T07:42:18Z

backport branch-3.0

✅ Backports have been created

#30709 [Enhancement] Support overflow mode for decimal type (backport #30419) has been created for branch branch-3.0 but encountered conflicts

mergify · 2023-09-11T07:42:29Z

backport branch-2.5

✅ Backports have been created

#30710 [Enhancement] Support overflow mode for decimal type (backport #30419) has been created for branch branch-2.5 but encountered conflicts

Signed-off-by: liuyehcf <[email protected]> (cherry picked from commit 228c120) # Conflicts: # gensrc/thrift/InternalService.thrift

Signed-off-by: liuyehcf <[email protected]> (cherry picked from commit 228c120) # Conflicts: # be/src/exprs/function_context.cpp # be/src/exprs/function_context.h # be/src/exprs/vectorized/arithmetic_expr.cpp # be/src/exprs/vectorized/arithmetic_operation.h # be/src/exprs/vectorized/cast_expr.cpp # be/src/exprs/vectorized/decimal_binary_function.h # be/src/exprs/vectorized/decimal_cast_expr.h # be/test/exprs/vectorized/decimal_binary_function_test.cpp # fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java # gensrc/thrift/InternalService.thrift

Signed-off-by: liuyehcf <[email protected]> (cherry picked from commit 228c120) # Conflicts: # be/test/exprs/decimal_binary_function_test.cpp # gensrc/thrift/InternalService.thrift

#30710) Signed-off-by: liuyehcf <[email protected]> Co-authored-by: liuyehcf <[email protected]>

#30709) Signed-off-by: liuyehcf <[email protected]> Co-authored-by: liuyehcf <[email protected]>

#30708) Signed-off-by: liuyehcf <[email protected]> Co-authored-by: liuyehcf <[email protected]>

mergify bot assigned liuyehcf Sep 5, 2023

github-actions bot added 3.1 3.0 2.5 labels Sep 5, 2023

liuyehcf force-pushed the decimal_overflow branch 6 times, most recently from de6045b to 031650c Compare September 7, 2023 10:51

[Enhancement] Support overflow mode for decimal type

cfd787f

Signed-off-by: liuyehcf <[email protected]>

liuyehcf force-pushed the decimal_overflow branch from 031650c to cfd787f Compare September 8, 2023 00:21

update 1

014f9e5

Signed-off-by: liuyehcf <[email protected]>

liuyehcf force-pushed the decimal_overflow branch from ecdea0f to 014f9e5 Compare September 8, 2023 03:44

satanson previously approved these changes Sep 11, 2023

View reviewed changes

fzhedu reviewed Sep 11, 2023

View reviewed changes

update 2

0542f80

Signed-off-by: liuyehcf <[email protected]>

liuyehcf dismissed satanson’s stale review via 0542f80 September 11, 2023 03:00

satanson approved these changes Sep 11, 2023

View reviewed changes

fzhedu approved these changes Sep 11, 2023

View reviewed changes

fzhedu merged commit 228c120 into StarRocks:main Sep 11, 2023
27 of 28 checks passed

github-actions bot removed the 3.1 label Sep 11, 2023

github-actions bot removed the 3.0 label Sep 11, 2023

kangkaisen approved these changes Sep 11, 2023

View reviewed changes

github-actions bot removed the 2.5 label Sep 11, 2023

mergify bot mentioned this pull request Sep 11, 2023

[Enhancement] Support overflow mode for decimal type (backport #30419) #30708

Merged

mergify bot pushed a commit that referenced this pull request Sep 11, 2023

[Enhancement] Support overflow mode for decimal type (#30419)

7923802

Signed-off-by: liuyehcf <[email protected]> (cherry picked from commit 228c120) # Conflicts: # gensrc/thrift/InternalService.thrift

This was referenced Sep 11, 2023

[Enhancement] Support overflow mode for decimal type (backport #30419) #30709

Merged

[Enhancement] Support overflow mode for decimal type (backport #30419) #30710

Merged

liuyehcf added a commit that referenced this pull request Sep 11, 2023

[Enhancement] Support overflow mode for decimal type (backport #30419) (

fed3b22

#30710) Signed-off-by: liuyehcf <[email protected]> Co-authored-by: liuyehcf <[email protected]>

liuyehcf added a commit that referenced this pull request Sep 12, 2023

[Enhancement] Support overflow mode for decimal type (backport #30419) (

8a24a39

#30709) Signed-off-by: liuyehcf <[email protected]> Co-authored-by: liuyehcf <[email protected]>

liuyehcf added a commit that referenced this pull request Sep 12, 2023

[Enhancement] Support overflow mode for decimal type (backport #30419) (

1d2a360

#30708) Signed-off-by: liuyehcf <[email protected]> Co-authored-by: liuyehcf <[email protected]>

github-actions bot added 3.1 3.0 2.5 labels Sep 13, 2023

wanpengfei-git added the backport_ok label Dec 5, 2023

packy92 mentioned this pull request May 9, 2024

ERROR_IF_OVERFLOW sql mode doesn‘t take effect in functions like avg #45346

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Support overflow mode for decimal type #30419

[Enhancement] Support overflow mode for decimal type #30419

liuyehcf commented Sep 5, 2023 •

edited

Loading

fzhedu Sep 11, 2023 •

edited

Loading

liuyehcf Sep 11, 2023

sonarcloud bot commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

mergify bot commented Sep 11, 2023 •

edited

Loading

mergify bot commented Sep 11, 2023 •

edited

Loading

mergify bot commented Sep 11, 2023 •

edited

Loading

[Enhancement] Support overflow mode for decimal type #30419

[Enhancement] Support overflow mode for decimal type #30419

Conversation

liuyehcf commented Sep 5, 2023 • edited Loading

Main work

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

fzhedu Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

liuyehcf Sep 11, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

[FE Incremental Coverage Report]

file detail

wanpengfei-git commented Sep 11, 2023

[BE Incremental Coverage Report]

file detail

wanpengfei-git commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

wanpengfei-git commented Sep 11, 2023

mergify bot commented Sep 11, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Sep 11, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Sep 11, 2023 • edited Loading

✅ Backports have been created

liuyehcf commented Sep 5, 2023 •

edited

Loading

fzhedu Sep 11, 2023 •

edited

Loading

mergify bot commented Sep 11, 2023 •

edited

Loading

mergify bot commented Sep 11, 2023 •

edited

Loading

mergify bot commented Sep 11, 2023 •

edited

Loading