Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support overflow mode for decimal type (backport #30419) #30708

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 11, 2023

This is an automatic backport of pull request #30419 done by Mergify.
Cherry-pick of 228c120 has failed:

On branch mergify/bp/branch-3.1/pr-30419
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 228c12035b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exprs/arithmetic_expr.cpp
	modified:   be/src/exprs/arithmetic_operation.h
	modified:   be/src/exprs/cast_expr.cpp
	modified:   be/src/exprs/decimal_binary_function.h
	modified:   be/src/exprs/decimal_cast_expr.h
	modified:   be/src/exprs/expr_context.cpp
	modified:   be/src/exprs/expr_context.h
	modified:   be/src/exprs/function_context.cpp
	modified:   be/src/exprs/function_context.h
	modified:   be/src/exprs/math_functions.h
	new file:   be/src/exprs/overflow.h
	modified:   be/src/runtime/runtime_state.h
	modified:   be/test/exprs/decimal_binary_function_test.cpp
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/SqlModeHelper.java
	new file:   test/sql/test_decimal/R/test_decimal_overflow
	new file:   test/sql/test_decimal/T/test_decimal_overflow

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   gensrc/thrift/InternalService.thrift

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: liuyehcf <[email protected]>
(cherry picked from commit 228c120)

# Conflicts:
#	gensrc/thrift/InternalService.thrift
@mergify
Copy link
Contributor Author

mergify bot commented Sep 11, 2023

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-30419 branch September 11, 2023 07:43
@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 73 / 126 (57.94%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exprs/decimal_binary_function.h 0 17 00.00% [65, 72, 84, 85, 88, 89, 92, 93, 94, 98, 102, 106, 107, 108, 109, 194, 225]
🔵 src/exprs/arithmetic_expr.cpp 8 25 32.00% [71, 77, 83, 89, 114, 115, 138, 139, 141, 142, 143, 145, 146, 160, 180, 204, 205]
🔵 src/exprs/cast_expr.cpp 8 19 42.11% [1086, 1088, 1109, 1110, 1111, 1112, 1113, 1114, 1119, 1121, 1289]
🔵 src/exprs/math_functions.h 1 2 50.00% [377]
🔵 src/exprs/arithmetic_operation.h 7 14 50.00% [87, 91, 92, 99, 100, 105, 110]
🔵 src/exprs/function_context.cpp 4 4 100.00% []
🔵 src/exprs/decimal_cast_expr.h 44 44 100.00% []
🔵 src/runtime/runtime_state.h 1 1 100.00% []

@liuyehcf liuyehcf restored the mergify/bp/branch-3.1/pr-30419 branch September 12, 2023 01:28
@liuyehcf liuyehcf reopened this Sep 12, 2023
Signed-off-by: liuyehcf <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@liuyehcf liuyehcf merged commit 1d2a360 into branch-3.1 Sep 12, 2023
18 checks passed
@liuyehcf liuyehcf deleted the mergify/bp/branch-3.1/pr-30419 branch September 12, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants