[FSDP] Add argument validation for FA3 with cp #1367
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopSoda2002
reviewed
Jan 13, 2026
Collaborator
PopSoda2002
left a comment
PopSoda2002
left a comment
There was a problem hiding this comment.
Thanks for the working, I think CP currently needs to be enabled with a enable_experimental flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ring attention implementation does not support Flash Attention 3 yet. Using --attn-implementation flash_attention_3 with --context-parallel-size > 1 would silently cause NaN loss during training. This change adds an early validation check
that raises a clear error with actionable guidance.