Skip to content

[FSDP] Add argument validation for FA3 with cp #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Beichen-Ma wants to merge 3 commits into from
Closed

[FSDP] Add argument validation for FA3 with cp #1367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29a72f8
add validation for FA3 with cp
Beichen-Ma Jan 9, 2026
4db8ae4
Merge branch 'main' into fsdp-cp-fa3-validation
Beichen-Ma Jan 9, 2026
e82340e
Merge branch 'main' into fsdp-cp-fa3-validation
Beichen-Ma Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions slime/utils/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1701,6 +1701,16 @@ def slime_validate_args(args):
args.use_dynamic_batch_size is False
), "Dynamic batch size is not supported for bshd format. Please specify --micro-batch-size instead."

if (
args.train_backend == "fsdp"
and getattr(args, "context_parallel_size", 1) > 1
and getattr(args, "attn_implementation", None) == "flash_attention_3"
):
raise ValueError(
"FSDP context parallelism implementation does not support flash_attention_3 for now. "
f"context_parallel_size={args.context_parallel_size} and attn_implementation='flash_attention_3'. "
"Please use --attn-implementation flash_attention_2 or set --context-parallel-size 1."
)

def hf_validate_args(args, hf_config):
def equal(x, y):
Expand Down