Sample Data: document, update scripts to validate, update tests#162
Sample Data: document, update scripts to validate, update tests#162SorenSpicknall merged 75 commits intomainfrom
Conversation
Also - update errors/clarity in datapackage.json template
- rename tides-data-package.json --> tides-datapackage-profile.json to be consistent with how other frictionless profiles are named and reduce confusion with an actual data package. - Add 4 shell scripts to /bin: (1) utilities to check presence of packages, files etc. and provide good help messages (2) update a datapackage file temporarily to point to another spec location (3) validate a datapackage file to the tides datapackage profile (4) validate a datapackage and its contents - Update contributing.md documentation - Removes table-schema.json b/c I don't thik we needed it - Updates tests/ files to have three primary scripts to run: (1) test_local_spec which valdiates the local spec (2) test_samples_to_canonical which validates the local samples to the canonical spec and (3) test_samples_to_local which validates local samples to local spec. - Updates table schemas to be a string location to be consistent with most other profiles rather than an object.
|
Documentation available at: |
|
Documentation available at: |
Superceded.
|
Documentation available at: |
|
Documentation available at: |
|
Data Validation Report
|
|
Data Validation Report
|
|
Data Validation Report
|
|
Data Validation Report
|
|
@e-lo, this PR includes the first commit of these samples, After working around a bundle of issues related to JSON parsing/transport between different steps in the validation workflow, I kicked off two runs of validation (one with errors and one without) to show that the GitHub workflow works on both - prior to the JSON parsing changes, the validation step and/or the comment publishing step would fail to complete on any non-passing data (for multiple reasons that probably aren't worth going into here). I changed the ref in Other than that follow-up task at merge time, this looks ready to me! |
Pull Request
This Pull Request composes the necessary documentation and tests to develop, validate, and navigate TIDES data samples.
Documentation:
samples/README.md(which then is added to the/samplespage of documentation)samples.md(which becomes the/samplespage of the documentation)tides-datapackage-profileCONTRIBUTING.mddocumentationCode:
samples/template/scripts/create_template_files.pywhich updates the template files based on the fields in the various table schemas. note: this isn't run automagically anywhere b/c I think this wasn't a universally desired feature2 Add validation script
/bin/validate-datapackage: validate a datapackage and its contents based on profile/spec specified in the datapackage, a local spec, or a remote spec based on its github reference./bin/validate-datapackage-to-profile: validate a datapackage file to the tides datapackage profile based on profile/spec specified in the datapackage, a local spec, or a remote spec based on its github reference.tests/test_allinto three scripts that we may want to use with different behaviors:test_local_specvalidates the local spec, documentation, and codetest_samples_to_canonicalvalidates the local samples to the canonical spec andtest_samples_to_localvalidates local samples to local specSpec:
tides-datapackage-profiletable schemas to be a string location to be consistent with most other profiles rather than an object.tides-datapackage-profileexamples to make it easier to use in documentation.table-schema.jsonb/c I don't think we needed itReplaces #100 which was mistakenly from a fork...
By contributing to this project, all contributors certify to the Developer Certificate of Origin in CONTRIBUTING.md.