chore: minato 0.18.9 - #54
Merged
Merged
Conversation
The pool asks whether a connection is still alive before handing it over, so a database restart no longer costs one failed query per pooled connection. A job queue polls continuously, so it meets a bounced database sooner than most callers do.
🟠 Code Coverage — 57.4%1015 of 1769 lines covered. 🟡 ELP Lint — 1 warning1 diagnostic found. See job logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks minato at 0.18.9, up from 0.18.8.
The pool now asks whether a connection is still alive before handing it over (Taure/minato#39). Previously a database restart, a failover, or an administrator ending a backend cost one failed query per pooled connection:
This is worth having in a job queue in particular. shigoto polls continuously and holds pooled connections for the life of the node, so it meets a bounced database sooner than most callers, and a spurious failure there turns into a job that looks like it failed rather than one that was never attempted.
The check is one syscall against a network round trip, measured at 330,665ns per pooled query versus 332,085ns without - inside the noise.
82 eunit and 110 ct green. fmt, xref and dialyzer clean.