Repository navigation
Use Groundwork 4.3.2 in docs - #351
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: Require
@usace/groundwork^4.3.2in the docs app and refresh the lockfile from 4.3.1. Groundwork 4.3.2 contains the upstream fix for browser-side Reactrequire()calls.Changes: Add an empty changeset because this updates docs validation and dependencies without changing the Groundwork Water package.
Testing:
npm ciandnpm run buildpassed after installing@usace-watermanagement/groundwork-water@latest.Testing: Local production preview rendered the docs homepage with no browser console errors.
Related: Follow-up to Use Groundwork 4 in docs #324 and Fix Changesets release checks and docs deployment #333. Resolves the dependency portion of Updating Groundwork and Groundwork Water Leading to Errors #319. Upstream fix: USACE/groundwork#300.